-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish necessary properties for external use of KZG commitment #232
Publish necessary properties for external use of KZG commitment #232
Conversation
…of_query Publish properties of `ProverQuery` and `VerifierQuery` to external
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make getter functions instead of exposing the fields? The idea is that while we allow to retrieve this, we signal that they should not be edited.
Does it make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Still not 100% convinced that this should be exposed. But anyways, don't see strong reasons to prevent it. Aside that users might get confused thinking that this is needed for anything if you want to use the crate on a normal way.
This pull request was created to solve the issue that mentioned in #230