Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish necessary properties for external use of KZG commitment #232

Merged
merged 5 commits into from
Nov 24, 2023
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 45 additions & 12 deletions halo2_proofs/src/poly/query.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,26 @@ pub trait Query<F>: Sized + Clone + Send + Sync {
/// A polynomial query at a point
#[derive(Debug, Clone)]
pub struct ProverQuery<'com, C: CurveAffine> {
/// point at which polynomial is queried
pub(crate) point: C::Scalar,
/// coefficients of polynomial
pub(crate) poly: &'com Polynomial<C::Scalar, Coeff>,
/// blinding factor of polynomial
pub(crate) blind: Blind<C::Scalar>,
/// Point at which polynomial is queried
pub point: C::Scalar,
/// Coefficients of polynomial
pub poly: &'com Polynomial<C::Scalar, Coeff>,
/// Blinding factor of polynomial
pub blind: Blind<C::Scalar>,
}

impl<'com, C> ProverQuery<'com, C>
where
C: CurveAffine,
{
/// Create a new prover query based on a polynomial
pub fn new(
chiro-hiro marked this conversation as resolved.
Show resolved Hide resolved
point: C::Scalar,
poly: &'com Polynomial<C::Scalar, Coeff>,
blind: Blind<C::Scalar>,
) -> Self {
ProverQuery { point, poly, blind }
}
}

#[doc(hidden)]
Expand Down Expand Up @@ -81,12 +95,31 @@ impl<'com, C: CurveAffine, M: MSM<C>> VerifierQuery<'com, C, M> {
/// A polynomial query at a point
#[derive(Debug)]
pub struct VerifierQuery<'com, C: CurveAffine, M: MSM<C>> {
/// point at which polynomial is queried
pub(crate) point: C::Scalar,
/// commitment to polynomial
pub(crate) commitment: CommitmentReference<'com, C, M>,
/// evaluation of polynomial at query point
pub(crate) eval: C::Scalar,
/// Point at which polynomial is queried
pub point: C::Scalar,
/// Commitment to polynomial
pub commitment: CommitmentReference<'com, C, M>,
/// Evaluation of polynomial at query point
pub eval: C::Scalar,
}

impl<'com, C, M> VerifierQuery<'com, C, M>
where
C: CurveAffine,
M: MSM<C>,
{
/// Create a new verifier query based on a commitment
pub fn new(
chiro-hiro marked this conversation as resolved.
Show resolved Hide resolved
point: C::Scalar,
commitment: CommitmentReference<'com, C, M>,
eval: C::Scalar,
) -> Self {
VerifierQuery {
point,
commitment,
eval,
}
}
}

impl<'com, C: CurveAffine, M: MSM<C>> Clone for VerifierQuery<'com, C, M> {
chiro-hiro marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading