Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved CollectionListRowBase to be a functional component #2415

Merged

Conversation

aviroopjana
Copy link
Contributor

Fixes #issue-number 2358

Changes:
Refer #2358
Converted the Legacy React class component to the Functional component.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Sep 11, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@lindapaiste
Copy link
Collaborator

It's very strange that every single line in the file is showing up as a "change" in git, even the lines that are the same. I wonder if your computer uses a different line break character or something like that.

@aviroopjana
Copy link
Contributor Author

@lindapaiste can you tell me, what should I do to make this PR mergeable because I too unable to figure out why this is showing

Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done!

…collection-list

# Conflicts:
#	client/modules/IDE/components/CollectionList/CollectionListRow.jsx
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you patience on this. I didn't review it right away because we had another PR pending which impacted this component. That one finally got approved and it created a bunch of conflicts with your PR so I went in and merged the two branches together. I still don't know why every line here is showing up as a change but I'm gonna merge it anyways.

@lindapaiste lindapaiste merged commit a3cf391 into processing:develop Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants