Update upload action to avoid deprecation warning

[cecille]

upload-artifact@v3 was deprecated. This was used by upload-pages-artifact@v1. v3 has the fix, see
https://github.com/actions/upload-pages-artifact/releases/tag/v3.0.0

[jcps07]

try using sha:

uses: actions/upload-pages-artifact@0252fc4ba7626f0298f0cf00902a25c6afc77fa8

[Alami-Amine]

I think even actions/configure-pages@v3 needs to be changed to actions/configure-pages@v5

[Alami-Amine]

Also we should change
thollander/actions-comment-pull-request@v2 to
thollander/actions-comment-pull-request@v3

I think this is the culprit

[Alami-Amine]

hilarious commit messages 😆

• I just came across someone who had the same issue, can you try changing pull_request_target to pull_request, apparently pull_request_target will run the workflow in the main instead of the workflow changed in the PR... which is so strange, we gotta document that :
  https://github.com/orgs/community/discussions/122045#discussioncomment-9367949

[cecille]

YES! Amine - I think you're onto something. The pull_request one is now failing with a new error. No idea why pull request target is still running, but it's possible if I get pull_request working we can shove this through and see that disappear.

This also seems like a github bug because if this is running from the workflow on main, then it's showing the wrong workflow file in the summary.

[Alami-Amine]

This is all so strange, why do you still have an action called pull_request_target?

[Alami-Amine]

according to this: https://runs-on.com/github-actions/pull-request-vs-pull-request-target/#the-pull_request_target-event-trigger

pull_request_target has full access to secrets, so I guess now we have to find out how to access secrets without pull_request_target

[Alami-Amine]

could you also add workflow_dispatch please?

[github-actions]

Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-40