Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload action to avoid deprecation warning #40

Merged
merged 19 commits into from
Feb 11, 2025
Merged

Update upload action to avoid deprecation warning #40

Changes from 2 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6203f8b
Update upload action to avoid deprecation warning
cecille Jan 31, 2025
c4eb9ce
Update .github/workflows/pr-preview.yaml
cecille Jan 31, 2025
4edf7e5
Testing in CI FTW
cecille Feb 10, 2025
3c69dab
Bisecting in public
cecille Feb 10, 2025
03e2cb4
the search narrows...hopefully
cecille Feb 10, 2025
bf14b22
seriously???
cecille Feb 10, 2025
96e42eb
ok...really...what's going on here
cecille Feb 10, 2025
61fea36
Restore original - this HAS to be coming from somewhere else
cecille Feb 10, 2025
6cc793e
HUUUUGOOOOOgit add -pgit add -p
cecille Feb 10, 2025
4e54a18
why won't you go home? Are you too good for your home? Answer me
cecille Feb 11, 2025
38a3b36
Amine, if this works I owe you a drink
cecille Feb 11, 2025
7588e6a
thowing things at the wall to see what sticks...
cecille Feb 11, 2025
034a8ff
no dice
cecille Feb 11, 2025
15cfbf9
is the problem the var or the secrets?
cecille Feb 11, 2025
dca1f11
Area 51: SECRET_TEST
cecille Feb 11, 2025
decb9c0
poke
cecille Feb 11, 2025
6aa301f
going back to target so we can have secrets
cecille Feb 11, 2025
a8b6d54
Change back the target on close
cecille Feb 11, 2025
12e9343
Merge remote-tracking branch 'upstream/main' into fix_artifact_error
cecille Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/pr-preview.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ defaults:

jobs:
build-preview:
if: github.repository == 'project-chip/matter-handbook'
if: github.repository == 'project-chip/matter-handbook'
runs-on: ubuntu-latest
env:
HUGO_VERSION: 0.115.4
steps:
- name: Install Hugo CLI
run: |
wget -O ${{ runner.temp }}/hugo.deb https://github.com/gohugoio/hugo/releases/download/v${HUGO_VERSION}/hugo_extended_${HUGO_VERSION}_linux-amd64.deb \
&& sudo dpkg -i ${{ runner.temp }}/hugo.deb
&& sudo dpkg -i ${{ runner.temp }}/hugo.deb
- name: Install Dart Sass
run: sudo snap install dart-sass
- name: Checkout
Expand All @@ -51,9 +51,9 @@ jobs:
hugo \
--gc \
--minify \
--baseURL "/pr-${{ github.event.number }}"
--baseURL "/pr-${{ github.event.number }}"
- name: Upload artifact
uses: actions/upload-pages-artifact@v1
uses: actions/upload-pages-artifact@v3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try using sha:

uses: actions/upload-pages-artifact@0252fc4ba7626f0298f0cf00902a25c6afc77fa8

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think even actions/configure-pages@v3 needs to be changed to actions/configure-pages@v5

with:
path: ./public
- name: Deploy preview
Expand All @@ -64,7 +64,7 @@ jobs:
AWS_S3_BUCKET: ${{ secrets.AWS_S3_BUCKET }}
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
SOURCE_DIR: './public'
SOURCE_DIR: './public'
DEST_DIR: 'pr-${{ github.event.number }}'
- name: Invalidate CloudFront
uses: chetan/invalidate-cloudfront-action@v2
Expand Down
Loading