-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove contour xDS server implementation #6568
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6568 +/- ##
==========================================
- Coverage 81.07% 80.72% -0.36%
==========================================
Files 134 131 -3
Lines 20087 19799 -288
==========================================
- Hits 16286 15983 -303
- Misses 3507 3526 +19
+ Partials 294 290 -4
|
0a90610
to
70b2eff
Compare
88cf463
to
cef7058
Compare
Calling this one ready for review, are others comfortable moving forward with this cleanup? |
yep I'll take a look! |
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apologies i thought we had merged this already, I think the empty struct thing was the only comment i had, LGTM!
Closes projectcontour#2134. Signed-off-by: Steve Kriss <[email protected]>
Signed-off-by: Steve Kriss <[email protected]>
Signed-off-by: Steve Kriss <[email protected]>
57a6c34
to
644846f
Compare
Merge conflicts resolved |
Closes #2134.