Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(json-ocsf): Remove risk field from unmapped #3759

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

pedrooot
Copy link
Member

Description

Since new field 'risk_details' has been added to json-ocsf ocsf/ocsf-schema#1032 it is needed to remove it from the unmapped field

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested a review from a team April 12, 2024 07:32
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.75%. Comparing base (ad3b0b3) to head (96e7913).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3759      +/-   ##
==========================================
- Coverage   85.77%   85.75%   -0.03%     
==========================================
  Files         722      722              
  Lines       22464    22463       -1     
==========================================
- Hits        19269    19263       -6     
- Misses       3195     3200       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one!! Thanks @pedrooot

@jfagoagas jfagoagas merged commit e9117f9 into master Apr 12, 2024
11 of 12 checks passed
@jfagoagas jfagoagas deleted the remove-risk-ocsf branch April 12, 2024 08:55
sergargar pushed a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants