Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(json-ocsf): Remove risk field from unmapped #3759

Merged
merged 2 commits into from
Apr 12, 2024
Merged

fix(json-ocsf): Remove risk field from unmapped #3759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c557adf
fix(json-ocsf): remove risk field from unmapped
pedrooot Apr 12, 2024
96e7913
fix: docs
jfagoagas Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/tutorials/reporting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ The following is the mapping between the native JSON and the Detection Finding f
| ResourceType | resources.type |
| ResourceDetails | _Not mapped yet_ |
| Description | finding_info.desc |
| Risk | unmapped.risk |
| Risk | risk_details _Available from OCSF 1.2_ |
| RelatedUrl | unmapped.related_url |
| Remediation.Recommendation.Text | remediation.desc |
| Remediation.Recommendation.Url | remediation.references |
Expand Down
1 change: 0 additions & 1 deletion prowler/lib/outputs/json_ocsf/json_ocsf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ def fill_json_ocsf(finding_output: FindingOutput) -> DetectionFinding:
type_name=DetectionFindingTypeID.Create.name,
unmapped={
"check_type": finding_output.check_type,
"risk": finding_output.risk,
"related_url": finding_output.related_url,
"categories": finding_output.categories,
"depends_on": finding_output.depends_on,
Expand Down
1 change: 0 additions & 1 deletion tests/lib/outputs/json_ocsf/json_ocsf_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ def test_finding_output_cloud_pass_low_muted(self):
# Unmapped Data
assert finding_json_ocsf.unmapped == {
"check_type": finding_output.check_type,
"risk": finding_output.risk,
"related_url": finding_output.related_url,
"categories": finding_output.categories,
"depends_on": finding_output.depends_on,
Expand Down