Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make basic models compatible with experiments #3995

Merged
merged 17 commits into from
May 9, 2024

Merge branch 'develop' into basic-experiments

f214f3c
Select commit
Loading
Failed to load commit list.
Merged

Make basic models compatible with experiments #3995

Merge branch 'develop' into basic-experiments
f214f3c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed May 7, 2024 in 0s

98.27% of diff hit (target 99.59%)

View this Pull Request on Codecov

98.27% of diff hit (target 99.59%)

Annotations

Check warning on line 409 in pybamm/models/full_battery_models/lithium_ion/basic_dfn_composite.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

pybamm/models/full_battery_models/lithium_ion/basic_dfn_composite.py#L409 

Added line #L409 was not covered by tests
View more details on Codecov