Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make basic models compatible with experiments #3995

Merged
merged 17 commits into from
May 9, 2024

Merge branch 'develop' into basic-experiments

f214f3c
Select commit
Loading
Failed to load commit list.
Merged

Make basic models compatible with experiments #3995

Merge branch 'develop' into basic-experiments
f214f3c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 7, 2024 in 1s

99.58% (-0.01%) compared to 448450b

View this Pull Request on Codecov

99.58% (-0.01%) compared to 448450b

Details

Codecov Report

Attention: Patch coverage is 98.27586% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.58%. Comparing base (448450b) to head (f214f3c).
Report is 3 commits behind head on develop.

Files Patch % Lines
..._battery_models/lithium_ion/basic_dfn_composite.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3995      +/-   ##
===========================================
- Coverage    99.59%   99.58%   -0.01%     
===========================================
  Files          259      260       +1     
  Lines        21353    21358       +5     
===========================================
+ Hits         21266    21270       +4     
- Misses          87       88       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov