Postpone removal of non-bare names in egg fragment to 25.1 #13159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
added
the
skip news
|
In light of #11617 (comment), we could also update the issue link to point to #13157 so users can actually talk to us if needed. Thoughts? |
Yes, let's do that. |
The only way for editable VCS URL installs to request an extra is to place them in the egg fragment. Of course, this is undocumented and deprecated behaviour, but we should ensure `pip install -e name[extra] @ VCS_URL` actually works before breaking our users.
sbidoul
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only way for editable VCS URL installs to request an extra is to place them in the egg fragment. Of course, this is undocumented and deprecated behaviour, but we should ensure
pip install -e name[extra] @ VCS_URLactually works (aka PR #9471) before breaking our users.See also: #13157 and #1289