-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of EUMETSAT IASI-NG reader #2879
base: main
Are you sure you want to change the base?
Initial implementation of EUMETSAT IASI-NG reader #2879
Conversation
Alright, so I see from the workflows above that there are some failures due to the formatting of the file, I should maybe start with this before moving forward with the remaining code changes 😉. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2879 +/- ##
==========================================
+ Coverage 96.06% 96.09% +0.02%
==========================================
Files 373 375 +2
Lines 54465 54952 +487
==========================================
+ Hits 52321 52805 +484
- Misses 2144 2147 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11174487208Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…atpy into eum_iasi_ng_reader_impl
Hi everyone, We now think that this MR is ready for a review by the Satpy team, so please let me know if you have any feedback on it. Thanks 😉! |
This PR introduces the initial implementation of the IASI-NG reader for Satpy.
The changes provided here are self-contained in three files:
satpy/readers/iasi_ng_l2_nc.py
: The implementation file for the reader.satpy/etc/readers/iasi_ng_l2_nc.yaml
: The YAML configuration file for the reader.satpy/tests/reader_tests/test_iasi_ng_l2_nc.py
: The unit tests for the reader.There are still a few points I need to address (this list may be extended progressively):
print(...)
statements).AUTHORS.md
file.The idea here is to start this PR early in the development phase to get early feedback and review notes from you, ensuring we are on the right track for eventual PR acceptance.
If you have any feedback on this PR already, please let me know 😊! In the meantime, I will continue working on the points mentioned above and will provide additional details on the changes as they are made on the feature branch.
Thanks for your help 🙏!