Initial implementation of EUMETSAT IASI-NG reader #2879
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Oct 4, 2024 in 35s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Code Health of new files: 9.49
- Declining Code Health: 2 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication test_iasi_ng_l2_nc.py
- Complex Method iasi_ng_l2_nc.py: IASINGL2NCFileHandler.register_available_datasets
Annotations
Check warning on line 476 in satpy/tests/reader_tests/test_iasi_ng_l2_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Code Duplication
The module contains 5 functions with similar structure: TestIASINGL2NCReader.test_ignore_pattern_variable,TestIASINGL2NCReader.test_ignore_scalar_variable,TestIASINGL2NCReader.test_process_variable,TestIASINGL2NCReader.test_register_available_datasets and 1 more functions. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Check warning on line 229 in satpy/readers/iasi_ng_l2_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
IASINGL2NCFileHandler.register_available_datasets has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Loading