-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear up DelftBlue tutorial #359
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I added a Test failures are unrelated, this PR is docs only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
ema_workbench/em_framework/points.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the reason for these changes? It's just to make sure we use the modern super call? but if so, it should be its own (maintenance) PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The super stuff points.py
was automatically added by pre-commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased, after the merge of #357 it's now gone from this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, excellent. LGTM unless you expect further changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this PR, this is it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A few minor clarifications to the DelftBlue part of the MPI tutorial.
This makes sure users don't accidently keep using an older version if they installed it previously.
* Clear up DelftBlue tutorial A few minor clarifications to the DelftBlue part of the MPI tutorial. * MPI tutorial: pip upgrade existing EMAworkbench installation This makes sure users don't accidently keep using an older version if they installed it previously.
A few minor clarifications to the DelftBlue part of the MPI tutorial.