add Navier-Stokes Characteristic Boundary Conditions #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…quokka into BenWibking/new-shock-cloud
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
…quokka into BenWibking/new-shock-cloud
for more information, see https://pre-commit.ci
…o BenWibking/NSCBC
BenWibking
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BenWibking
changed the title
|
@markkrumholz This is a bit of a hefty PR, so please let me know if I should split it into smaller pieces and/or anything else that would be helpful in reviewing. |
|
/azp run |
|
OK, will have a look, but it may not be until tomorrow or Friday due to other commitments. |
|
/azp run |
|
/azp run |
1 similar comment
|
/azp run |
markkrumholz
approved these changes
Aug 31, 2023
markkrumholz
approved these changes
Aug 31, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
This updates the shock-cloud problem to use a new setup that:
- tracks the cloud center-of-mass frame
- refines so that the cooling length $l_{\text{cool}} = c_s
t_{\text{cool}}$ is resolved with at least 10 cells
- adds derived fields for temperature, entropy, pressure, etc. to the
outputs
- uses the (simplified) Navier-Stokes Characteristic Boundary Conditions
for inflow/outflow on the left/right sides of the box
- adds shock-cloud problem to nightly regression testing
**This PR depends on:**
* #352
* #360
* #363
* #364
* #365
* #366
* #367
* #430
* #581
* #596
* #597
* #598
* #599
* #616
* #645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Navier-Stokes Characteristic Boundary Conditions (NSCBC) from Motheau, Almgren & Bell, AIAA, Vol. 55, No. 10, 2017:
The relevant boundary conditions are for subsonic inflow and subsonic outflow. The inflow boundary conditions are only partially implemented (for the x-direction lower boundary, for the exclusive purpose of running one of the test problems from the paper). The outflow BC is implemented for all faces.
We do not include the special treatment of the corner boundaries that is done in the paper. (It may be necessary to implement this in the future if we want to have adjacent outflow-outflow boundaries.)
Two test problems are included:
Additionally, this adds exhaustive debugging output that can be enabled at runtime for all temporary/work MultiFabs used during the hydro update (including all ghost zones). This should only be enabled for debugging purposes, as it outputs every MultiFab used during every timestep.