Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct units for mean molecular weight #494

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

psharda
Copy link
Contributor

@psharda psharda commented Jan 11, 2024

Description

Bug fix to use consistent units and dimensions for EOS_Traits

Related issues

Resolves #493

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • [x ] I have added a description (see above).
  • [x ] I have added a link to any related issues see (see above).
  • [x ] I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • [x ] I have requested a reviewer for this PR.

@psharda psharda marked this pull request as ready for review January 11, 2024 12:25
@BenWibking
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@psharda
Copy link
Contributor Author

psharda commented Jan 12, 2024

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@BenWibking BenWibking added this pull request to the merge queue Jan 12, 2024
Merged via the queue into quokka-astro:development with commit ad85a58 Jan 12, 2024
10 of 13 checks passed
@psharda psharda deleted the bugfix branch February 5, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Units of EOS_traits should always be the same
2 participants