Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct units for mean molecular weight #494

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Use correct units for mean molecular weight #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
280107b
use correct units for mean molecular weight
psharda Jan 11, 2024
3f837ee
Merge branch 'development' into bugfix
psharda Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/HydroBlast2D/test_hydro2d_blast.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ struct BlastProblem {

template <> struct quokka::EOS_Traits<BlastProblem> {
static constexpr double gamma = 5. / 3.;
static constexpr double mean_molecular_weight = 1.0;
static constexpr double mean_molecular_weight = C::m_u;
static constexpr double boltzmann_constant = C::k_B;
};

Expand Down
2 changes: 1 addition & 1 deletion src/HydroBlast3D/test_hydro3d_blast.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ bool test_passes = false; // if one of the energy checks fails, set to false

template <> struct quokka::EOS_Traits<SedovProblem> {
static constexpr double gamma = 1.4;
static constexpr double mean_molecular_weight = 1.0;
static constexpr double mean_molecular_weight = C::m_u;
static constexpr double boltzmann_constant = C::k_B;
};

Expand Down
2 changes: 1 addition & 1 deletion src/HydroHighMach/test_hydro_highmach.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ struct HighMachProblem {

template <> struct quokka::EOS_Traits<HighMachProblem> {
static constexpr double gamma = 5. / 3.;
static constexpr double mean_molecular_weight = 1.0;
static constexpr double mean_molecular_weight = C::m_u;
static constexpr double boltzmann_constant = C::k_B;
};

Expand Down
2 changes: 1 addition & 1 deletion src/HydroKelvinHelmholz/test_hydro2d_kh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ struct KelvinHelmholzProblem {

template <> struct quokka::EOS_Traits<KelvinHelmholzProblem> {
static constexpr double gamma = 1.4;
static constexpr double mean_molecular_weight = 1.0;
static constexpr double mean_molecular_weight = C::m_u;
static constexpr double boltzmann_constant = C::k_B;
};

Expand Down
2 changes: 1 addition & 1 deletion src/HydroQuirk/test_quirk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ struct QuirkProblem {

template <> struct quokka::EOS_Traits<QuirkProblem> {
static constexpr double gamma = 5. / 3.;
static constexpr double mean_molecular_weight = 1.0;
static constexpr double mean_molecular_weight = C::m_u;
static constexpr double boltzmann_constant = C::k_B;
};

Expand Down
2 changes: 1 addition & 1 deletion src/HydroRichtmeyerMeshkov/test_hydro2d_rm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ struct RichtmeyerMeshkovProblem {

template <> struct quokka::EOS_Traits<RichtmeyerMeshkovProblem> {
static constexpr double gamma = 1.4;
static constexpr double mean_molecular_weight = 1.0;
static constexpr double mean_molecular_weight = C::m_u;
static constexpr double boltzmann_constant = C::k_B;
};

Expand Down
2 changes: 1 addition & 1 deletion src/HydroShocktube/test_hydro_shocktube.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ struct ShocktubeProblem {

template <> struct quokka::EOS_Traits<ShocktubeProblem> {
static constexpr double gamma = 1.4;
static constexpr double mean_molecular_weight = 1.0;
static constexpr double mean_molecular_weight = C::m_u;
static constexpr double boltzmann_constant = C::k_B;
};

Expand Down
2 changes: 1 addition & 1 deletion src/HydroShocktubeCMA/test_hydro_shocktube_cma.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ template <> struct SimulationData<ShocktubeProblem> {

template <> struct quokka::EOS_Traits<ShocktubeProblem> {
static constexpr double gamma = 1.4;
static constexpr double mean_molecular_weight = 1.0;
static constexpr double mean_molecular_weight = C::m_u;
static constexpr double boltzmann_constant = C::k_B;
};

Expand Down
2 changes: 1 addition & 1 deletion src/HydroVacuum/test_hydro_vacuum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ struct ShocktubeProblem {

template <> struct quokka::EOS_Traits<ShocktubeProblem> {
static constexpr double gamma = 1.4;
static constexpr double mean_molecular_weight = 1.0;
static constexpr double mean_molecular_weight = C::m_u;
static constexpr double boltzmann_constant = C::k_B;
};

Expand Down
2 changes: 1 addition & 1 deletion src/RayleighTaylor2D/test_hydro2d_rt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ struct RTProblem {

template <> struct quokka::EOS_Traits<RTProblem> {
static constexpr double gamma = 1.4;
static constexpr double mean_molecular_weight = 1.0;
static constexpr double mean_molecular_weight = C::m_u;
static constexpr double boltzmann_constant = C::k_B;
};

Expand Down
2 changes: 1 addition & 1 deletion src/SphericalCollapse/spherical_collapse.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ struct CollapseProblem {

template <> struct quokka::EOS_Traits<CollapseProblem> {
static constexpr double gamma = 5. / 3.;
static constexpr double mean_molecular_weight = 1.0;
static constexpr double mean_molecular_weight = C::m_u;
static constexpr double boltzmann_constant = C::k_B;
};

Expand Down
2 changes: 1 addition & 1 deletion src/StarCluster/star_cluster.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ struct StarCluster {
template <> struct quokka::EOS_Traits<StarCluster> {
static constexpr double gamma = 1.0;
static constexpr double cs_isothermal = 1.0; // dimensionless
static constexpr double mean_molecular_weight = 1.0;
static constexpr double mean_molecular_weight = C::m_u;
static constexpr double boltzmann_constant = C::k_B;
};

Expand Down