Fix audio playback bugs due to setting speed #3040
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes bugs due to setting the playback speed on certain
devices, even if the person does not try to change the playback speed at
all. For example, on a Pixel 8, pausing the audio and resuming causes
the playback to stop ui wise without stopping service wise due to a
silent exception from setting the playback params.
The fix here, as suggested by Claude, is not re-using the playback
params, and, instead, setting a new one, irrespective of the current
values.