Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio playback bugs due to setting speed #3040

Merged
merged 1 commit into from
Jan 2, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -39,6 +39,7 @@ import android.media.MediaPlayer
import android.media.MediaPlayer.OnCompletionListener
import android.media.MediaPlayer.OnPreparedListener
import android.media.MediaPlayer.OnSeekCompleteListener
import android.media.PlaybackParams
import android.net.wifi.WifiManager
import android.net.wifi.WifiManager.WifiLock
import android.os.Build
@@ -661,10 +662,7 @@ class AudioService : Service(), OnCompletionListener, OnPreparedListener,
private fun processUpdatePlaybackSpeed(speed: Float) {
if (State.Playing === state && Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
try {
player?.playbackParams?.let { params ->
params.setSpeed(speed)
player?.playbackParams = params
}
player?.playbackParams = PlaybackParams().allowDefaults().setSpeed(speed)
} catch (e: Exception) {
// catch an Android 6 crash [IllegalStateException], and report the speed since some
// non-Android 6 devices also crash here, but with [IllegalArgumentException]
@@ -1070,12 +1068,13 @@ class AudioService : Service(), OnCompletionListener, OnPreparedListener,
"seek complete! %d vs %d",
mediaPlayer.currentPosition, player.currentPosition
)
player.start()
state = State.Playing
updateAudioPlaybackStatus()

audioRequest?.playbackSpeed?.let { speed ->
processUpdatePlaybackSpeed(speed)
}
player.start()
state = State.Playing
updateAudioPlaybackStatus()
serviceHandler.sendEmptyMessageDelayed(MSG_UPDATE_AUDIO_POS, 200)
}