Automated Resyntax fixes #1402
Open
Automated Resyntax fixes #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
This is an automated change generated by Resyntax. #### Pass 1 Applied 3 fixes to [`typed-racket-lib/typed-racket/base-env/annotate-classes.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/annotate-classes.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 172, `if-else-false-to-and`: This `if` expression can be refactored to an equivalent expression using `and`. * Line 331, `define-values-values-to-define`: This use of `define-values` is unnecessary. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/ann-inst.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/ann-inst.rkt) * Line 8, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-test/optimizer/reset-port.rkt`](../blob/HEAD/typed-racket-test/optimizer/reset-port.rkt) * Line 8, `read-line-any`: Specify a line mode of `'any` with `read-line` to avoid differences between Windows and other platforms. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/base-env-indexing-abs.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/base-env-indexing-abs.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 3 fixes to [`typed-racket-test/optimizer/transform.rkt`](../blob/HEAD/typed-racket-test/optimizer/transform.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 24, `read-line-any`: Specify a line mode of `'any` with `read-line` to avoid differences between Windows and other platforms. * Line 35, `if-begin-to-cond`: Using `cond` instead of `if` here makes `begin` unnecessary Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/prims-lambda.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/prims-lambda.rkt) * Line 9, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/base-env-indexing.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/base-env-indexing.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/unit-prims.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/unit-prims.rkt) * Line 136, `map-to-for`: This `map` operation can be replaced with a `for/list` loop. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/base-structs.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/base-structs.rkt) * Line 14, `provide-deduplication`: Providing the same identifier multiple times is unnecessary. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/class-prims.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/class-prims.rkt) * Line 5, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-test/optimizer/known-bugs.rkt`](../blob/HEAD/typed-racket-test/optimizer/known-bugs.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 2 fixes to [`typed-racket-lib/typed-racket/base-env/base-contracted.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/base-contracted.rkt) * Line 6, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 34, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/class-clauses.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/class-clauses.rkt) * Line 8, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/sequence.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/sequence.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/extra-env-lang.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/extra-env-lang.rkt) * Line 9, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/for-clauses.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/for-clauses.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/base-special-env.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/base-special-env.rkt) * Line 5, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/env-lang.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/env-lang.rkt) * Line 5, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/base-types-extra.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/base-types-extra.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 2 fixes to [`typed-racket-test/optimizer/run.rkt`](../blob/HEAD/typed-racket-test/optimizer/run.rkt) * Line 2, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 14, `read-line-any`: Specify a line mode of `'any` with `read-line` to avoid differences between Windows and other platforms. ## Summary Fixed 26 issues in 20 files. * Fixed 18 occurrences of `tidy-require` * Fixed 3 occurrences of `read-line-any` * Fixed 1 occurrence of `if-begin-to-cond` * Fixed 1 occurrence of `if-else-false-to-and` * Fixed 1 occurrence of `define-values-values-to-define` * Fixed 1 occurrence of `map-to-for` * Fixed 1 occurrence of `provide-deduplication`
jackfirth
added a commit
to jackfirth/resyntax
that referenced
this pull request
Oct 11, 2024
jackfirth
added a commit
to jackfirth/resyntax
that referenced
this pull request
Oct 11, 2024
|
It would be helpful in the future to group changes by rule (either into separate commits in a PR, separate PRs, separate parts of the PR description, etc). |
|
That's possible but very tricky because multiple passes are made in a single pull request. So it might be the case that it's not possible to split up the changes into individual commits by rule type. |
sorawee
reviewed
Oct 21, 2024
| @@ -5,7 +5,7 @@ | |||
| (provide read-syntax) | |||
|
|
|||
| (define (read-syntax name port) | |||
| (read-line port) | |||
| (read-line port 'any) | |||
There was a problem hiding this comment.
I know 'any is preferable in general, but does it break anything here?
There was a problem hiding this comment.
Oh, it's just for testing. Probably doesn't matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated change generated by Resyntax.
Pass 1
Applied 3 fixes to
typed-racket-lib/typed-racket/base-env/annotate-classes.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.if-else-false-to-and: Thisifexpression can be refactored to an equivalent expression usingand.define-values-values-to-define: This use ofdefine-valuesis unnecessary.Applied 1 fix to
typed-racket-lib/typed-racket/base-env/ann-inst.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-test/optimizer/reset-port.rktread-line-any: Specify a line mode of'anywithread-lineto avoid differences between Windows and other platforms.Applied 1 fix to
typed-racket-lib/typed-racket/base-env/base-env-indexing-abs.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 3 fixes to
typed-racket-test/optimizer/transform.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.read-line-any: Specify a line mode of'anywithread-lineto avoid differences between Windows and other platforms.if-begin-to-cond: Usingcondinstead ofifhere makesbeginunnecessaryApplied 1 fix to
typed-racket-lib/typed-racket/base-env/prims-lambda.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/base-env/base-env-indexing.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/base-env/unit-prims.rktmap-to-for: Thismapoperation can be replaced with afor/listloop.Applied 1 fix to
typed-racket-lib/typed-racket/base-env/base-structs.rktprovide-deduplication: Providing the same identifier multiple times is unnecessary.Applied 1 fix to
typed-racket-lib/typed-racket/base-env/class-prims.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-test/optimizer/known-bugs.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 2 fixes to
typed-racket-lib/typed-racket/base-env/base-contracted.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.tidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/base-env/class-clauses.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/optimizer/sequence.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/base-env/extra-env-lang.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/base-env/for-clauses.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/base-env/base-special-env.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/base-env/env-lang.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/base-env/base-types-extra.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 2 fixes to
typed-racket-test/optimizer/run.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.read-line-any: Specify a line mode of'anywithread-lineto avoid differences between Windows and other platforms.Summary
Fixed 26 issues in 20 files.
tidy-requireread-line-anyif-begin-to-condif-else-false-to-anddefine-values-values-to-definemap-to-forprovide-deduplication