-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated Resyntax fixes #1402
Open
resyntax-ci
wants to merge
1
commit into
master
Choose a base branch
from
autofix-5-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Automated Resyntax fixes #1402
Commits on Oct 11, 2024
-
This is an automated change generated by Resyntax. #### Pass 1 Applied 3 fixes to [`typed-racket-lib/typed-racket/base-env/annotate-classes.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/annotate-classes.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 172, `if-else-false-to-and`: This `if` expression can be refactored to an equivalent expression using `and`. * Line 331, `define-values-values-to-define`: This use of `define-values` is unnecessary. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/ann-inst.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/ann-inst.rkt) * Line 8, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-test/optimizer/reset-port.rkt`](../blob/HEAD/typed-racket-test/optimizer/reset-port.rkt) * Line 8, `read-line-any`: Specify a line mode of `'any` with `read-line` to avoid differences between Windows and other platforms. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/base-env-indexing-abs.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/base-env-indexing-abs.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 3 fixes to [`typed-racket-test/optimizer/transform.rkt`](../blob/HEAD/typed-racket-test/optimizer/transform.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 24, `read-line-any`: Specify a line mode of `'any` with `read-line` to avoid differences between Windows and other platforms. * Line 35, `if-begin-to-cond`: Using `cond` instead of `if` here makes `begin` unnecessary Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/prims-lambda.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/prims-lambda.rkt) * Line 9, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/base-env-indexing.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/base-env-indexing.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/unit-prims.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/unit-prims.rkt) * Line 136, `map-to-for`: This `map` operation can be replaced with a `for/list` loop. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/base-structs.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/base-structs.rkt) * Line 14, `provide-deduplication`: Providing the same identifier multiple times is unnecessary. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/class-prims.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/class-prims.rkt) * Line 5, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-test/optimizer/known-bugs.rkt`](../blob/HEAD/typed-racket-test/optimizer/known-bugs.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 2 fixes to [`typed-racket-lib/typed-racket/base-env/base-contracted.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/base-contracted.rkt) * Line 6, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 34, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/class-clauses.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/class-clauses.rkt) * Line 8, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/sequence.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/sequence.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/extra-env-lang.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/extra-env-lang.rkt) * Line 9, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/for-clauses.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/for-clauses.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/base-special-env.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/base-special-env.rkt) * Line 5, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/env-lang.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/env-lang.rkt) * Line 5, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/base-env/base-types-extra.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/base-env/base-types-extra.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 2 fixes to [`typed-racket-test/optimizer/run.rkt`](../blob/HEAD/typed-racket-test/optimizer/run.rkt) * Line 2, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 14, `read-line-any`: Specify a line mode of `'any` with `read-line` to avoid differences between Windows and other platforms. ## Summary Fixed 26 issues in 20 files. * Fixed 18 occurrences of `tidy-require` * Fixed 3 occurrences of `read-line-any` * Fixed 1 occurrence of `if-begin-to-cond` * Fixed 1 occurrence of `if-else-false-to-and` * Fixed 1 occurrence of `define-values-values-to-define` * Fixed 1 occurrence of `map-to-for` * Fixed 1 occurrence of `provide-deduplication`
Configuration menu - View commit details
-
Copy full SHA for c6e7f0c - Browse repository at this point
Copy the full SHA c6e7f0cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.