Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove macos_arm_size_report.json #287

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

abdelaziz-mahdy
Copy link
Contributor

@abdelaziz-mahdy abdelaziz-mahdy commented Nov 5, 2024

i just removed the upload json and the python script will auto adjust to the svg creation, i only commented it in case we needed to enable it for any reason

fixing: #282 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (dfe31bd) to head (6afaf0b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          49       49           
  Lines        9129     9129           
=======================================
  Hits         8402     8402           
  Misses        727      727           
Flag Coverage Δ
unittests 92.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abdelaziz-mahdy
Copy link
Contributor Author

i dont understand the failure errors :)

@rainyl
Copy link
Owner

rainyl commented Nov 5, 2024

Thanks! I will try to fix it.

@rainyl rainyl merged commit 356f019 into rainyl:main Nov 5, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants