Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove macos_arm_size_report.json #287

Merged
merged 5 commits into from
Nov 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/examples.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -488,10 +488,21 @@ jobs:
name: Generate Combined Size Reports
needs: [windows, android, ios, linux, macos, macos-arm]
runs-on: ubuntu-latest
permissions:
# Give the default GITHUB_TOKEN write permission to commit and push the
# added or changed files to the repository.
contents: write

steps:
- uses: actions/checkout@v4
with:
# Checkout the fork/head-repository and push changes to the fork.
# If you skip this, the base repository will be checked out and changes
# will be committed to the base repository!
repository: ${{ github.event.pull_request.head.repo.full_name }}

# Checkout the branch made in the fork. Will automatically push changes
# back to this branch.
ref: ${{ github.head_ref }}

# - name: Set up Python
Expand Down
2 changes: 1 addition & 1 deletion scripts/generate_combined_report.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def consolidate_data(reports: list) -> Dict[str, Any]:
data = json.load(f)
for package, sizes in data.items():
if (
package == "base_size" or package == "platform"
package == "base_size" or package == "platform" or platform.lower() == "macos_arm"
): # Skip platform mapping
continue
if package not in combined:
Expand Down
Loading