Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Optimizations for iOS and Android #6396

Closed
wants to merge 27 commits into from
Closed

Build Optimizations for iOS and Android #6396

wants to merge 27 commits into from

Conversation

takameyer
Copy link
Contributor

@takameyer takameyer commented Jan 19, 2024

What, How & Why?

  • iOS:
    • Build with core prebuilds and the source code needed to bind realm-js to core, as well as RN dependencies
    • Allows flexibility in the platform used as well
    • Option to build core from source
  • Android:
    • Flexible NDK version compiling
    • Use the consumers React Native version (deduced from Maven)
    • Breakpoints in core code (for internal debugging)

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@takameyer takameyer mentioned this pull request Jan 19, 2024
7 tasks
Copy link

coveralls-official bot commented Jan 19, 2024

Coverage Status

coverage: 85.833% (+0.5%) from 85.346%
when pulling 9b7b56d on andrew/bo/ios
into 474e395 on main.

@takameyer takameyer force-pushed the andrew/bo/reorg branch 2 times, most recently from 6992126 to 17269c7 Compare January 24, 2024 08:34
Base automatically changed from andrew/bo/reorg to main January 24, 2024 10:23
@takameyer takameyer force-pushed the andrew/bo/ios branch 2 times, most recently from 68fb769 to 2dfc2a4 Compare January 24, 2024 11:34
@cla-bot cla-bot bot added the cla: yes label Jan 25, 2024
@takameyer takameyer force-pushed the andrew/bo/ios branch 5 times, most recently from f1d1229 to d6f1a03 Compare January 30, 2024 16:03
takameyer and others added 17 commits February 5, 2024 12:02
Co-authored-by: LJ <[email protected]>
Co-authored-by: Kræn Hansen <[email protected]>
Update node16 actions
Refactor bundle step into generate artifact step
* Build Realm Android from Source

* Derive React Native version from local RN package

* Implement prefab to handle react native dependencies.  Refactor where possible

* Refactor CI for Android

* Fix pack issues

* Possible ios cache issue

* Fixed issue where build starts before ts is generated

* disable wireit cache

* refactor wireit cache and optimize workflow

* Cleanup packagin
Co-authored-by: Kræn Hansen <[email protected]>
Co-authored-by: Kenneth Geisshirt <[email protected]>
Co-authored-by: LJ <[email protected]>
* Rename generate script
* Various Cleanup
* Fix up the dependencies for the integration tests
@takameyer takameyer force-pushed the andrew/bo/ios branch 3 times, most recently from 994d432 to 8db294e Compare February 6, 2024 13:45
@kraenhansen
Copy link
Member

Closing this in favor of #6650 - thanks for all the work you put into this @takameyer! 🙂

@kraenhansen kraenhansen deleted the andrew/bo/ios branch May 24, 2024 17:10
@takameyer
Copy link
Contributor Author

Happy to see some of the learnings we made from this could help! 🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants