Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compability issues on Windows #22

Open
wants to merge 1 commit into
base: LinkStage3
Choose a base branch
from

Conversation

chenming-wu
Copy link

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:

  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.


@chenming-wu
Copy link
Author

I think most of them are minor fixes, and they won't affect the structure of the project.

@realthunder
Copy link
Owner

Can you please elaborate the reason of the changes? Do they cause compilation error? Which compiler do you use?

Also, the flex generated file, any reason you re-generate it?

@chenming-wu
Copy link
Author

chenming-wu commented Oct 23, 2019

Hi, yes, I was using Visual Studio 2019 (the latest update). Those changed contents can fix all the compilation errors I encountered.

I didn't know why I generated the flex file, I think it's not related to fixing those compilation errors. I would be happy to remove this committed file if you thought the other commits are acceptable.

@realthunder
Copy link
Owner

I didn't know why I generated the flex file, I think it's not related to fixing those compilation errors. I would be happy to remove this committed file if you thought the other commits are acceptable.

Yes, please revert that file and try again to see if there is any error.

Also, can you please change SoFCSelectionRoot::PASSTHROUGH to PASS_THROUGH and see if it is okay?

@realthunder realthunder force-pushed the LinkStage3 branch 2 times, most recently from 255a123 to 10a4cc2 Compare April 16, 2020 01:18
@realthunder realthunder force-pushed the LinkStage3 branch 5 times, most recently from 1830a52 to 27c53b4 Compare April 23, 2020 06:36
@realthunder realthunder force-pushed the LinkStage3 branch 2 times, most recently from 8a97ad7 to fac530c Compare June 28, 2020 07:07
@realthunder realthunder force-pushed the LinkStage3 branch 3 times, most recently from 73f279b to c1d8e4d Compare July 10, 2020 08:38
@realthunder realthunder force-pushed the LinkStage3 branch 2 times, most recently from d8c33d8 to e3d5306 Compare July 24, 2020 14:17
@dulouie dulouie mentioned this pull request Nov 8, 2020
@realthunder realthunder force-pushed the LinkStage3 branch 2 times, most recently from e0a9465 to 6f26068 Compare December 24, 2020 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants