Merge multiple Dockerfiles into a single one #2167
Conversation
Signed-off-by: Simon Zhao <[email protected]>
SimonYansenZhao
requested review from
miguelgfierro,
gramhagen,
anargyri,
loomlike and
wutaomsft
as code owners
Signed-off-by: Simon Zhao <[email protected]>
| @@ -1,189 +1,177 @@ | |||
| # syntax=docker/dockerfile:1 | |||
There was a problem hiding this comment.
What do you think of adding a new set up section in the instructions: https://github.com/recommenders-team/recommenders/blob/main/SETUP.md
We could explain how to install docker in a command line and how to do it with VSCode.
I'm particularly interested in the VSCode one.
What do you think?
There was a problem hiding this comment.
Sure, I will.
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
| @@ -27,24 +29,32 @@ | |||
| }, | |||
| "isort.args": ["--profile", "black"], | |||
| "python.analysis.autoImportCompletions": true, | |||
| "python.defaultInterpreterPath": "/usr/local/conda/envs/Recommenders/bin/python", | |||
| // Conda env name *must* align with ENV_HOME in Dockerfle | |||
There was a problem hiding this comment.
I think, as Miguel suggested, that it would be good to have the instructions in a SETUP page somewhere as well.
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
|
hi @SimonYansenZhao the tests should be working now after #2169 |
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
| # * [buildpack-deps:24.04](https://github.com/docker-library/buildpack-deps/blob/master/ubuntu/noble/Dockerfile) | ||
| # + [Created on 2024-08-17](https://hub.docker.com/layers/library/buildpack-deps/noble/images/sha256-dbfee7e7ee2340b0d6567efd3a8a9281ce45ee78598485b4d7a7f09fe641811a) | ||
| FROM buildpack-deps@sha256:dbfee7e7ee2340b0d6567efd3a8a9281ce45ee78598485b4d7a7f09fe641811a AS cpu |
There was a problem hiding this comment.
what is this? would it be possible to explain what it is and why we are using a specific sha?
There was a problem hiding this comment.
This base image is built on top of ubuntu by adding the essential tools for building packages such as gcc. Specifying the sha is for speeding up the image build, otherwise, it will pull the base image every time when there is a new release of the image.
Signed-off-by: Simon Zhao <[email protected]>
Description
This PR merges the following multiple uses of Dockerfile into a single place in
tools/docker/Dockerfilefor easier maintainance in the future:Related Issues
None
References
Checklist:
git commit -s -m "your commit message".staging branchAND NOT TOmain branch.