-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge multiple Dockerfiles into a single one #2167
Open
SimonYansenZhao
wants to merge
23
commits into
staging
Choose a base branch
from
simonz/dockerfile
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
89c7251
Merge multiple Dockerfiles into a single one
SimonYansenZhao 877066b
Correct pacakge path
SimonYansenZhao 50898de
Set DEBIAN_FRONTEND=noninteractive
SimonYansenZhao 5ee0343
set ENV DEBIAN_FRONTEND noninteractive
SimonYansenZhao 7a40c2f
Debugging
SimonYansenZhao deb6afc
Correct gpu base image digest
SimonYansenZhao 1688d89
Debugging
SimonYansenZhao b494c05
Debugging
SimonYansenZhao 3f59bb3
Move ARGs to inner scope
SimonYansenZhao d0c64f1
Move SHELL to the last stage
SimonYansenZhao 03c891f
Add DEBIAN_FRONTEND=noninteractive
SimonYansenZhao e56221c
Redeclare ARGs
SimonYansenZhao 424bd1a
Remove options for venv and virtualenv
SimonYansenZhao 4df5e5a
Source .bashrc to activate conda env
SimonYansenZhao 55206ae
Correct conda path
SimonYansenZhao 47a2b6e
Activate conda env
SimonYansenZhao 35a0b21
Init conda
SimonYansenZhao 2be5324
Correct extras
SimonYansenZhao ea39fc0
Set interactive bash
SimonYansenZhao a5325e2
Source .bashrc
SimonYansenZhao 393c1a0
Activate conda env by setting system env vars
SimonYansenZhao 2aebacf
Remove env vars defined in RUNs
SimonYansenZhao 3d8560e
Correct conda activate
SimonYansenZhao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, as Miguel suggested, that it would be good to have the instructions in a SETUP page somewhere as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure