HotFix: Fix the typo and keep code-server case-sensitive #122
Conversation
Signed-off-by: Harshad Reddy Nalla <[email protected]>
|
/lgtm |
| opendatahub.io/notebook-image-name: "Code server" | ||
| opendatahub.io/notebook-image-desc: "Code server workbench allows users to code, build, and collaborate on projects directly from web." | ||
| opendatahub.io/notebook-image-name: "code-server" | ||
| opendatahub.io/notebook-image-desc: "code-server workbench allows users to code, build, and collaborate on projects directly from web." |
There was a problem hiding this comment.
@jstourac collaborate? Do you know what feature this refers to specifically? Can more than one person access the code-server at the same time and use the web ui?
There was a problem hiding this comment.
all the workbenches can be accessed at the same time if the owner of the workbench provides access to the user.
example:
if multiple people have access to a DS project.
they all can use all the workbenches spined up in the DS project.
| @@ -17,7 +17,7 @@ spec: | |||
| # N Version of the image | |||
| - annotations: | |||
| opendatahub.io/notebook-software: '[{"name":"Python","version":"v3.9"}]' | |||
| opendatahub.io/notebook-python-dependencies: '[{"name":"Code-sever","version":"4.16"}]' | |||
| opendatahub.io/notebook-python-dependencies: '[{"name":"code-server","version":"4.16"}]' | |||
There was a problem hiding this comment.
+1, looks better than Code-server to me
|
As both QA and Dev team have signed off |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16, jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
harshad16
merged commit 0c19110
into
red-hat-data-services:release-2023b
HotFix: Fix the typo and keep code-server case-sensitive
Refer: https://redhat-internal.slack.com/archives/C05TTTYG599/p1706184360108179?thread_ts=1706112551.862629&cid=C05TTTYG599