Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotFix: Fix the typo and keep code-server case-sensitive #122

Merged
merged 1 commit into from
Jan 25, 2024
Merged

HotFix: Fix the typo and keep code-server case-sensitive #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions manifests/base/code-server-notebook-imagestream.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ metadata:
opendatahub.io/notebook-image: "true"
annotations:
opendatahub.io/notebook-image-url: "https://github.com/red-hat-data-services/notebooks/tree/main/codeserver"
opendatahub.io/notebook-image-name: "Code server"
opendatahub.io/notebook-image-desc: "Code server workbench allows users to code, build, and collaborate on projects directly from web."
opendatahub.io/notebook-image-name: "code-server"
opendatahub.io/notebook-image-desc: "code-server workbench allows users to code, build, and collaborate on projects directly from web."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstourac collaborate? Do you know what feature this refers to specifically? Can more than one person access the code-server at the same time and use the web ui?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the workbenches can be accessed at the same time if the owner of the workbench provides access to the user.
example:
if multiple people have access to a DS project.
they all can use all the workbenches spined up in the DS project.

opendatahub.io/notebook-image-order: "80"
name: code-server-notebook
spec:
Expand All @@ -17,7 +17,7 @@ spec:
# N Version of the image
- annotations:
opendatahub.io/notebook-software: '[{"name":"Python","version":"v3.9"}]'
opendatahub.io/notebook-python-dependencies: '[{"name":"Code-sever","version":"4.16"}]'
opendatahub.io/notebook-python-dependencies: '[{"name":"code-server","version":"4.16"}]'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, looks better than Code-server to me

openshift.io/imported-from: quay.io/modh/codeserver
opendatahub.io/workbench-image-recommended: 'true'
opendatahub.io/notebook-build-commit: $(odh-codeserver-notebook-image-commit-n)
Expand Down