Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image controller update to dev & stg #3624

Merged
merged 2 commits into from
Apr 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/image-controller/development/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../base
- https://github.com/redhat-appstudio/image-controller/config/default?ref=e5a29db5772c85b84d3246597e5b39f229d2925a
- https://github.com/redhat-appstudio/image-controller/config/default?ref=0f0b61cef9f667bb8a93d79fc03554fff9bb335b

images:
- name: quay.io/redhat-appstudio/image-controller
newName: quay.io/redhat-appstudio/image-controller
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshaposhnik the image ref probably needs to be updated according to this

Copy link
Member

@mmorhun mmorhun Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to use released image on dev & stage, so it shouldn't be changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so I guess release is probably not working well? since CI is failing due to quay.io/redhat-appstudio/image-controller not containing the required SHA

last time a tag was pushed to this repo was 22 days ago
Screenshot 2024-04-25 at 14 47 56

newTag: e5a29db5772c85b84d3246597e5b39f229d2925a
newTag: 0f0b61cef9f667bb8a93d79fc03554fff9bb335b

namespace: image-controller

Expand Down
4 changes: 2 additions & 2 deletions components/image-controller/staging/base/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ kind: Kustomization
resources:
- ../../base
- ../../base/external-secrets
- https://github.com/redhat-appstudio/image-controller/config/default?ref=e5a29db5772c85b84d3246597e5b39f229d2925a
- https://github.com/redhat-appstudio/image-controller/config/default?ref=0f0b61cef9f667bb8a93d79fc03554fff9bb335b

images:
- name: quay.io/redhat-appstudio/image-controller
newName: quay.io/redhat-appstudio/image-controller
newTag: e5a29db5772c85b84d3246597e5b39f229d2925a
newTag: 0f0b61cef9f667bb8a93d79fc03554fff9bb335b

namespace: image-controller

Expand Down
Loading