fix: add default labels to actions in plugin.xml (#957) #960
Conversation
adietish
force-pushed
the
issue-957
branch
2 times, most recently
from
0dde1e2 to
d4fbc1a
Compare
|
@sbouchet can you please review this? thanks! |
| <action class="org.jboss.tools.intellij.openshift.actions.component.DeployComponentAction" id="org.jboss.tools.intellij.openshift.actions.component.DeployComponentAction"/> | ||
| <action class="org.jboss.tools.intellij.openshift.actions.component.DevComponentAction" id="org.jboss.tools.intellij.openshift.actions.component.DevComponentAction" text="Dev Component"/> | ||
| <action class="org.jboss.tools.intellij.openshift.actions.component.DevOnPodmanComponentAction" id="org.jboss.tools.intellij.openshift.actions.component.DevOnPodmanComponentAction" text="Dev Podman Component" /> | ||
| <action class="org.jboss.tools.intellij.openshift.actions.component.DeployComponentAction" id="org.jboss.tools.intellij.openshift.actions.component.DeployComponentAction" text="Deploy Component" /> | ||
| </group> |
There was a problem hiding this comment.
nitpicking but those labels are already defined on the ComponentFeature class with :
"Dev on Cluster"
"Dev on Podman"
"Deploy on Cluster"
There was a problem hiding this comment.
@sbouchet yes, but IDEA seems to impose those as the error message implies:
The default action text must be specified in plugin.xml or its class constructor [Plugin: org.jboss.tools.intellij.openshift]
I dont see how we can reuse these with the plugin.xml or vice versa.
There was a problem hiding this comment.
yes but my point was more to reuse the same texts for default labels
There was a problem hiding this comment.
finally grocked 😃, corrected the labels.
Signed-off-by: Andre Dietisheim <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbouchet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override "ci/prow/e2e-openshift" |
|
@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
openshift-merge-bot
bot
merged commit ff97e67
into
redhat-developer:main
fixes #957