Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default labels to actions in plugin.xml (#957) #960

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: add default labels to actions in plugin.xml (#957) #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/resources/META-INF/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,9 +309,9 @@
<!-- component level -->
<separator/>
<group id="org.jboss.tools.intellij.openshift.actions.component.actions">
<action class="org.jboss.tools.intellij.openshift.actions.component.DevComponentAction" id="org.jboss.tools.intellij.openshift.actions.component.DevComponentAction"/>
<action class="org.jboss.tools.intellij.openshift.actions.component.DevOnPodmanComponentAction" id="org.jboss.tools.intellij.openshift.actions.component.DevOnPodmanComponentAction"/>
<action class="org.jboss.tools.intellij.openshift.actions.component.DeployComponentAction" id="org.jboss.tools.intellij.openshift.actions.component.DeployComponentAction"/>
<action class="org.jboss.tools.intellij.openshift.actions.component.DevComponentAction" id="org.jboss.tools.intellij.openshift.actions.component.DevComponentAction" text="Dev on Cluster"/>
<action class="org.jboss.tools.intellij.openshift.actions.component.DevOnPodmanComponentAction" id="org.jboss.tools.intellij.openshift.actions.component.DevOnPodmanComponentAction" text="Dev on Podman" />
<action class="org.jboss.tools.intellij.openshift.actions.component.DeployComponentAction" id="org.jboss.tools.intellij.openshift.actions.component.DeployComponentAction" text="Deploy on Cluster" />
</group>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking but those labels are already defined on the ComponentFeature class with :
"Dev on Cluster"
"Dev on Podman"
"Deploy on Cluster"

Copy link
Contributor Author

@adietish adietish Feb 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbouchet yes, but IDEA seems to impose those as the error message implies:

The default action text must be specified in plugin.xml or its class constructor [Plugin: org.jboss.tools.intellij.openshift]

I dont see how we can reuse these with the plugin.xml or vice versa.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but my point was more to reuse the same texts for default labels

Copy link
Contributor Author

@adietish adietish Feb 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally grocked 😃, corrected the labels.

<separator/>
<action class="org.jboss.tools.intellij.openshift.actions.component.DescribeComponentAction" id="org.jboss.tools.intellij.openshift.actions.component.DescribeComponentAction" text="Describe"/>
Expand Down
Loading