Drop lodash #926
Open
Drop lodash #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorkem
suggested changes
Oct 7, 2023
dimaMachina
reviewed
Oct 10, 2023
| @@ -33,6 +33,7 @@ | |||
| "prettier": "2.8.7" | |||
| }, | |||
| "dependencies": { | |||
| "@types/lodash.clonedeep": "^4.5.7", | |||
| "ajv": "^8.11.0", | |||
| "lodash": "4.17.21", | |||
There was a problem hiding this comment.
you need to remove lodash
Suggested change
| "lodash": "4.17.21", |
dimaMachina
reviewed
Oct 10, 2023
| @@ -33,6 +33,7 @@ | |||
| "prettier": "2.8.7" | |||
| }, | |||
| "dependencies": { | |||
| "@types/lodash.clonedeep": "^4.5.7", | |||
dimaMachina
reviewed
Oct 10, 2023
| @@ -33,6 +33,7 @@ | |||
| "prettier": "2.8.7" | |||
| }, | |||
| "dependencies": { | |||
There was a problem hiding this comment.
you forget to install lodash.clonedeep
dimaMachina
reviewed
Oct 10, 2023
| @@ -26,7 +26,7 @@ import { CST, isMap, isSeq, YAMLMap } from 'yaml'; | |||
| import { yamlDocumentsCache } from '../parser/yaml-documents'; | |||
| import { FlowStyleRewriter } from '../utils/flow-style-rewriter'; | |||
| import { ASTNode } from '../jsonASTTypes'; | |||
| import * as _ from 'lodash'; | |||
| import cloneDeep from '@types/lodash.clonedeep'; | |||
There was a problem hiding this comment.
Suggested change
| import cloneDeep from '@types/lodash.clonedeep'; | |
| import cloneDeep from 'lodash.clonedeep'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reduce number files in node_modules (problematic on windows)
What issues does this PR fix or reference?
Reduce time necessary to extract zipped node_modules on windows
Is it tested? How?
I used modified version in wildwebdeveloper