-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop lodash #926
base: main
Are you sure you want to change the base?
Drop lodash #926
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -33,6 +33,7 @@ | |||
"prettier": "2.8.7" | ||||
}, | ||||
"dependencies": { | ||||
"@types/lodash.clonedeep": "^4.5.7", | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be devDependency |
||||
"ajv": "^8.11.0", | ||||
"lodash": "4.17.21", | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you need to remove lodash
Suggested change
|
||||
"request-light": "^0.5.7", | ||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -26,7 +26,7 @@ | |||||
import { yamlDocumentsCache } from '../parser/yaml-documents'; | ||||||
import { FlowStyleRewriter } from '../utils/flow-style-rewriter'; | ||||||
import { ASTNode } from '../jsonASTTypes'; | ||||||
import * as _ from 'lodash'; | ||||||
import cloneDeep from '@types/lodash.clonedeep'; | ||||||
Check failure on line 29 in src/languageservice/services/yamlCodeActions.ts GitHub Actions / build (ubuntu-latest)
Check failure on line 29 in src/languageservice/services/yamlCodeActions.ts GitHub Actions / build (ubuntu-latest)
|
||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
import { SourceToken } from 'yaml/dist/parse/cst'; | ||||||
|
||||||
interface YamlDiagnosticData { | ||||||
|
@@ -247,7 +247,7 @@ | |||||
node = node.parent; | ||||||
} | ||||||
if (node && isMap(node.internalNode)) { | ||||||
const sorted: YAMLMap = _.cloneDeep(node.internalNode); | ||||||
const sorted: YAMLMap = cloneDeep(node.internalNode); | ||||||
if ( | ||||||
(sorted.srcToken.type === 'block-map' || sorted.srcToken.type === 'flow-collection') && | ||||||
(node.internalNode.srcToken.type === 'block-map' || node.internalNode.srcToken.type === 'flow-collection') | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -415,6 +415,18 @@ | |
resolved "https://registry.npmjs.org/@types/json5/-/json5-0.0.29.tgz" | ||
integrity sha512-dRLjCWHYg4oaA77cxO64oO+7JwCwnIzkZPdrrC71jQmQtlhM556pwKo5bUzqvZndkVbeFLIIi+9TC40JNF5hNQ== | ||
|
||
"@types/lodash.clonedeep@^4.5.7": | ||
version "4.5.7" | ||
resolved "https://registry.yarnpkg.com/@types/lodash.clonedeep/-/lodash.clonedeep-4.5.7.tgz#0e119f582ed6f9e6b373c04a644651763214f197" | ||
integrity sha512-ccNqkPptFIXrpVqUECi60/DFxjNKsfoQxSQsgcBJCX/fuX1wgyQieojkcWH/KpE3xzLoWN/2k+ZeGqIN3paSvw== | ||
dependencies: | ||
"@types/lodash" "*" | ||
|
||
"@types/lodash@*": | ||
version "4.14.199" | ||
resolved "https://registry.yarnpkg.com/@types/lodash/-/lodash-4.14.199.tgz#c3edb5650149d847a277a8961a7ad360c474e9bf" | ||
integrity sha512-Vrjz5N5Ia4SEzWWgIVwnHNEnb1UE1XMkvY5DGXrAeOGE9imk0hgTHh5GyDjLDJi9OTCn9oo9dXH1uToK1VRfrg== | ||
|
||
"@types/[email protected]": | ||
version "8.2.2" | ||
resolved "https://registry.npmjs.org/@types/mocha/-/mocha-8.2.2.tgz" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you forget to install
lodash.clonedeep