Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modify): Add x-jsf-presentation shorthand #81

Merged
merged 3 commits into from
Jul 25, 2024
Merged

feat(modify): Add x-jsf-presentation shorthand #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9f24b9
feat(modify): Allow customize x-jsf-presentation shorthand
sandrina-p Jul 18, 2024
b3ca957
selfreview - fix test compare
sandrina-p Jul 19, 2024
e189f5f
update test to match new specs
sandrina-p Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/modify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@ function mergeReplaceArray(_, newVal) {
}

function standardizeAttrs(attrs) {
const { errorMessage, properties, ...rest } = attrs;
const { errorMessage, presentation, properties, ...rest } = attrs;
sandrina-p marked this conversation as resolved.
Show resolved Hide resolved

return {
...rest,
...(presentation ? { 'x-jsf-presentation': presentation } : {}),
...(errorMessage ? { 'x-jsf-errorMessage': errorMessage } : {}),
};
}
Expand Down
42 changes: 41 additions & 1 deletion src/tests/modify.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ describe('modify() - basic mutations', () => {
});
});

it('error message', () => {
it('customize x-jsf-errorMessage (shorthand)', () => {
const result = modify(schemaPet, {
fields: {
pet_age: (fieldAttrs) => {
Expand Down Expand Up @@ -396,4 +396,44 @@ describe('modify() - basic mutations', () => {
},
});
});

it('customize x-jsf-presentation (shorthand)', () => {
const result = modify(schemaPet, {
fields: {
pet_age: () => {
return {
presentation: {
'data-foo': 123,
},
};
},
'pet_address.street': {
errorMessage: {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was not correct, I fixed it directly in another PR as hotfix 76bb765. (Thank you @danielcardoso5 for spotting it 🦅 )

'data-foo': 456,
},
},
},
});

expect(result.schema).toMatchObject({
sandrina-p marked this conversation as resolved.
Show resolved Hide resolved
properties: {
pet_age: {
'x-jsf-presentation': {
...schemaPet.properties.pet_age['x-jsf-presentation'],
'data-foo': 123,
},
},
pet_address: {
properties: {
street: {
'x-jsf-errorMessage': {
...schemaPet.properties.pet_address.properties.street['x-jsf-presentation'],
'data-foo': 456,
},
},
},
},
},
});
});
});
Loading