Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modify): Add x-jsf-presentation shorthand #81

Merged
merged 3 commits into from
Jul 25, 2024
Merged

feat(modify): Add x-jsf-presentation shorthand #81

merged 3 commits into from
Jul 25, 2024

Conversation

sandrina-p
Copy link
Collaborator

@sandrina-p sandrina-p commented Jul 18, 2024 •
edited
Loading

Follow-up of #75, but now also allowing to customize x-jsf-presentation more easily with just presentation:

Linear issue (internal)

Before:

modify(schemaPet, {
  fields: {
    pet_age: {
      'x-jsf-presentation': {
        'data-foo': 123,
      },
    }
  },
});

Now

modify(schemaPet, {
  fields: {
    pet_age: {
      presentation: {
        'data-foo': 123,
      },
    },
  },
});

@sandrina-p sandrina-p self-assigned this Jul 19, 2024
eng-almeida
eng-almeida previously approved these changes Jul 19, 2024
View reviewed changes
dilvane
dilvane previously approved these changes Jul 22, 2024
View reviewed changes
@sandrina-p sandrina-p dismissed stale reviews from dilvane and eng-almeida via bd93ab9 July 24, 2024 10:54
@sandrina-p sandrina-p force-pushed the RMT-777-document-modify--presentation branch from 3afd4df to bd93ab9 Compare July 24, 2024 10:54
@sandrina-p sandrina-p force-pushed the RMT-777-document-modify--presentation branch from bd93ab9 to e189f5f Compare July 24, 2024 13:03
@sandrina-p sandrina-p changed the title feat(modify): Allow customize x-jsf-presentation shorthand feat(modify): Add x-jsf-presentation shorthand Jul 25, 2024
@sandrina-p sandrina-p merged commit 7cfaab0 into main Jul 25, 2024
3 checks passed
@sandrina-p sandrina-p deleted the RMT-777-document-modify--presentation branch July 25, 2024 15:37
@sandrina-p sandrina-p mentioned this pull request Jul 25, 2024
Merged
sandrina-p added a commit that referenced this pull request Jul 25, 2024
@sandrina-p
hotfix previous PR #81 (presentation shorthand) with false positive t…
76bb765 
…est about
sandrina-p
sandrina-p commented Jul 25, 2024
View reviewed changes
src/tests/modify.test.js
};
},
'pet_address.street': {
errorMessage: {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was not correct, I fixed it directly in another PR as hotfix 76bb765. (Thank you @danielcardoso5 for spotting it 🦅 )

sandrina-p added a commit that referenced this pull request Jul 25, 2024
@sandrina-p
feat(modify): Allow picking fields (#79)
2e04402 
* feat(modify): Support picking fields

* Better warning msg

* Update specs to match last decisions

* Release 0.11.0-dev.20240725074901

* better error msg

* Revert back to 0.10.0-beta.0

* fix manually the version to match main 0.10.1-beta.0

* hotfix previous PR #81 (presentation shorthand) with false positive test about
@sandrina-p sandrina-p mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilvane dilvane dilvane approved these changes

@eng-almeida eng-almeida eng-almeida left review comments

Assignees

@sandrina-p sandrina-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandrina-p @dilvane @eng-almeida