Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re enable tests #2894

Closed
wants to merge 10 commits into from
Closed

chore: re enable tests #2894

wants to merge 10 commits into from

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Sep 20, 2024

Description

  • Removes .only
  • Fixes issue where connectExternal  would set the activeNamespace causing strange behaviors. setActiveNamespace should be called only internally. Clients already update state internally via setCaipNetwork

Type of change

  • Bug Fix

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: 37fcaa6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview Sep 21, 2024 6:24pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 21, 2024 6:24pm

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 239.36999999999998% 4103 / 10388
🔵 Statements 239.36999999999998% 4103 / 10388
🔵 Functions 269.14% 319 / 803
🔵 Branches 311.43% 562 / 1031
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/appkit/src/client.ts 82.98% 75.78% 86.25% 82.98% 82-83, 102-103, 106-107, 110-111, 114-115, 118-121, 124-127, 130-131, 256, 300-303, 403, 405-407, 410-411, 413-415, 440-441, 456-457, 460-461, 464-465, 474-476, 485, 519-523, 527, 536-548
packages/core/src/controllers/ChainController.ts 61.73% 46.34% 64.7% 61.73% 73-77, 80-84, 86-87, 89-97, 103-104, 131, 133-143, 147-155, 165-166, 189-190, 226-231, 233-237, 239-240, 242-256, 260-261, 274-275, 278-281, 292-294, 296-297, 306-307, 326-328, 330-331, 334-335, 340-341, 344-345, 357-358, 361-362, 367-368, 380-381, 386-387, 393, 395-400, 402-403, 406, 408-413, 415-416, 422-423
packages/core/src/controllers/ConnectionController.ts 57.25% 90.9% 26.08% 57.25% 72-76, 83-84, 105-107, 110-123, 126-127, 130-131, 134-135, 138-139, 142-143, 146-147, 150-151, 154-155, 171-172, 175-177, 180-181, 184-185, 188-189, 198-199
packages/core/src/controllers/NetworkController.ts 61.02% 68.57% 70.58% 61.02% 46-47, 53-56, 58-67, 75-76, 95-101, 114-115, 121-122, 136-139, 153, 155-156, 158-165, 168-169, 171-173, 175-176, 178, 180-184, 186-187, 195-196, 208-209, 226-227, 230-231, 244-245, 255, 257-259, 261-262, 266
Generated in workflow #6240

Copy link
Contributor

github-actions bot commented Sep 20, 2024

♻️ Vite-Size ♻️

Size Difference

Size (kb) Gzip (kb)
Total Diff. 0 0

Current Size

Name Size (kb) Gzip (kb)
assets/index-lM2-ETAn.js 1866.871 532.903
assets/index.js 9.63 3.159
assets/index2.js 11.572 3.198
assets/w3m-modal.js 7.397 2.614
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.115
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.443 25.589
index.html 0.329 0.237
Total Size 2411.616 698.205

Base Size

Name Size (kb) Gzip (kb)
assets/index-lM2-ETAn.js 1866.871 532.903
assets/index.js 9.63 3.159
assets/index2.js 11.572 3.198
assets/w3m-modal.js 7.397 2.614
assets/noble-curves.js 31.941 12.778
assets/2.21.4_bufferutil.js 2.789 1.327
assets/index3.js 102.251 29.115
assets/index4.js 304.393 87.285
assets/hooks.module.js 74.443 25.589
index.html 0.329 0.237
Total Size 2411.616 698.205

@tomiir tomiir changed the title chore: remove .only on test chore: re enable tests Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants