Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: re enable tests #2894

Closed
wants to merge 10 commits into from
Closed

chore: re enable tests #2894

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a29fa17
chore: remove .only on test
tomiir Sep 20, 2024
f2294e7
Merge branch 'main' of github.com:WalletConnect/web3modal into fix/re…
tomiir Sep 20, 2024
034a38e
fix: setActiveNamespace and undefined chain Ids causing default to eth
tomiir Sep 20, 2024
a611126
chore: rollback getAccounts change
tomiir Sep 20, 2024
243fda7
chore: remove wrong test
tomiir Sep 20, 2024
ba9d178
fix: modal auto closing
tomiir Sep 20, 2024
5f53c43
chore: remove logs
tomiir Sep 20, 2024
140e726
fix: issue switching to a different namespace
tomiir Sep 20, 2024
ceb1bad
fix: empty caip network on soala adapter
tomiir Sep 20, 2024
37fcaa6
fix: solana session not updated on namespace switch
tomiir Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/laboratory/tests/multichain/multichain-wagmi-solana.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ test.skip('it should show disabled networks', async () => {
await modalPage.closeModal()
})

test.only('it should switch networks and sign', async () => {
test('it should switch networks and sign', async () => {
const chains = ['Polygon', 'Solana']

async function processChain(index: number) {
Expand Down
3 changes: 1 addition & 2 deletions packages/adapters/wagmi/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,8 +645,8 @@ export class WagmiAdapter implements ChainAdapter {
}
} else if (status === 'connected' && address && chainId) {
const caipAddress = `eip155:${chainId}:${address}` as CaipAddress
this.syncNetwork(address, chainId, true)
this.appKit?.setCaipAddress(caipAddress, this.chainNamespace)
await this.syncNetwork(address, chainId, true)
await Promise.all([
this.syncProfile(address, chainId),
this.syncBalance(address, chainId),
Expand Down Expand Up @@ -683,7 +683,6 @@ export class WagmiAdapter implements ChainAdapter {

private async syncNetwork(address?: Hex, chainId?: number, isConnected?: boolean) {
const chain = this.caipNetworks.find((c: CaipNetwork) => c.chainId === chainId)

if (chain && chainId) {
this.appKit?.setCaipNetwork({
chainId: chain.chainId,
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/controllers/ConnectionController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ export const ConnectionController = {
async connectExternal(options: ConnectExternalOptions, chain: ChainNamespace, setChain = true) {
await this._getClient(chain).connectExternal?.(options)
if (setChain) {
ChainController.setActiveNamespace(chain)
StorageUtil.setConnectedConnector(options.type)
}
},
Expand Down
Loading