Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to load all EVM wallets from api.web3modal.org #2961

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kprigel
Copy link

@kprigel kprigel commented Sep 27, 2024

Description

Current Behavior

  • createAppKit queries api.web3modal.org for wallet support based on the active chain.
  • The number of wallets returned varies significantly across chains (e.g., 380+ for Ethereum mainnet, 60 for Base, 3 for Base Sepolia).
  • The API response is not exhaustive, omitting some wallets that support specific chains (e.g., Coinbase Wallet for Base and Base Sepolia).

Proposed Change

  • Introduce a new allEthWallets state variable for createAppKit.
  • When allEthWallets is true, the API query will always use eip155:1 (Ethereum mainnet) as the chain parameter.

Benefits

  • Provides a more comprehensive list of potentially compatible wallets across all EVM-compatible chains.
  • Improves user experience by showing more wallet options, especially for newer or less popular chains.

Implementation

  • Add allEthWallets option to createAppKit configuration.
  • Modify API call logic to use eip155:1 when allEthWallets is enabled.

Notes

  • This change assumes that wallets supporting Ethereum mainnet are likely to support other EVM-compatible chains, instead of relying solely on API responses.
  • Further testing may be required to ensure this doesn't introduce false positives for wallet compatibility.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

None

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Sep 27, 2024

⚠️ No Changeset found

Latest commit: 04dbcbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Oct 1, 2024 3:35am

Copy link

vercel bot commented Sep 27, 2024

@kprigel is attempting to deploy a commit to the Reown Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant