-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): per provider integration tests #465
Conversation
runs-on: ubuntu-latest | ||
if: needs.providers-list.outputs.providers != '[]' | ||
strategy: | ||
fail-fast: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to fail all providers in case of one for cases like: we are manually validating a list of providers and want to know if there is a global issue or just one provider fails.
fi | ||
done | ||
|
||
PROVIDERS_LIST="${PROVIDERS_LIST% }" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing whitespace at the end.
PROVIDERS_LIST="${PROVIDERS_LIST% }" | ||
fi | ||
|
||
JSON_FMT=$(printf '[%s]' "$(echo $PROVIDERS_LIST | awk '{for(i=1;i<=NF;i++) printf "\"%s\",", $i}' | sed 's/,$//')") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making JSON array from a space separated list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered jq
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not installed by default, so it's not worth to install it for one line.
bdc5fc6
to
60c304d
Compare
60c304d
to
218f284
Compare
|
||
JSON_FMT=$(printf '[%s]' "$(echo $PROVIDERS_LIST | awk '{for(i=1;i<=NF;i++) printf "\"%s\",", $i}' | sed 's/,$//')") | ||
echo "providers=$JSON_FMT" >> $GITHUB_OUTPUT | ||
- name: Print list of changed providers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave this step for debugging purposes.
Description
The context of the issue (#464):
This PR introduces the following changes:
#[ignore]
{provider_name}_provider
patternResolves #464
How Has This Been Tested?
Tested only partly because of the GitHub CI nature.
The
sub-providers.yml
workflow was tested isolated and reduced in the forked repo by pushing different commits on it:Due Diligence