Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Increase default goldpinger timeouts and add goldpinger troubleshoot spec #4977

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Dec 11, 2023

What this PR does / why we need it:

  • Increases goldpinger addon timeouts. In slowish networks, pings tend to fail unnecessarily. The default ping timeout is 300ms.
  • Add a support bundle spec whenever goldpinger addon is added to a kurl spec.

Which issue(s) this PR fixes:

Fixes #sc-91987

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

NONE

Does this PR require documentation?

NONE

@banjoh banjoh requested a review from a team as a code owner December 11, 2023 15:17
@banjoh banjoh marked this pull request as draft December 11, 2023 15:17
@banjoh banjoh added the type::feature An enhancement to an existing add on or feature label Dec 11, 2023
@banjoh banjoh changed the title Increase default goldpinger timeouts feat: Increase default goldpinger timeouts and add goldpinger troubleshoot spec Dec 11, 2023
@banjoh banjoh marked this pull request as ready for review December 11, 2023 18:29
@banjoh banjoh closed this Dec 12, 2023
@banjoh banjoh deleted the em/goldping-timeouts-and-troubleshoot-spec branch December 12, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature An enhancement to an existing add on or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant