Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Increase default goldpinger timeouts and add goldpinger troubleshoot spec #4977

Closed
wants to merge 2 commits into from
Closed

feat: Increase default goldpinger timeouts and add goldpinger troubleshoot spec #4977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7075854
Increase default goldpinger timeouts
banjoh Dec 11, 2023
3abd281
Add goldpinger support bundle spec
banjoh Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion addons/goldpinger/3.2.0-4.1.1/goldpinger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ spec:
app.kubernetes.io/name: goldpinger
app.kubernetes.io/instance: goldpinger
spec:
priorityClassName:
priorityClassName:
serviceAccountName: goldpinger
containers:
- name: goldpinger-daemon
Expand All @@ -107,6 +107,12 @@ spec:
valueFrom:
fieldRef:
fieldPath: status.podIP
- name: PING_TIMEOUT_MS
value: 2000
- name: CHECK_TIMEOUT_MS
value: 3000
- name: CHECK_ALL_TIMEOUT_MS
value: 10000
ports:
- name: http
containerPort: 80
Expand Down
8 changes: 7 additions & 1 deletion addons/goldpinger/3.2.0-4.2.1/goldpinger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ spec:
app.kubernetes.io/name: goldpinger
app.kubernetes.io/instance: goldpinger
spec:
priorityClassName:
priorityClassName:
serviceAccountName: goldpinger
containers:
- name: goldpinger-daemon
Expand All @@ -107,6 +107,12 @@ spec:
valueFrom:
fieldRef:
fieldPath: status.podIP
- name: PING_TIMEOUT_MS
value: 2000
- name: CHECK_TIMEOUT_MS
value: 3000
- name: CHECK_ALL_TIMEOUT_MS
value: 10000
ports:
- name: http
containerPort: 80
Expand Down
8 changes: 7 additions & 1 deletion addons/goldpinger/3.2.0-5.0.0/goldpinger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ spec:
app.kubernetes.io/name: goldpinger
app.kubernetes.io/instance: goldpinger
spec:
priorityClassName:
priorityClassName:
serviceAccountName: goldpinger
containers:
- name: goldpinger-daemon
Expand All @@ -112,6 +112,12 @@ spec:
valueFrom:
fieldRef:
fieldPath: status.podIP
- name: PING_TIMEOUT_MS
value: 2000
- name: CHECK_TIMEOUT_MS
value: 3000
- name: CHECK_ALL_TIMEOUT_MS
value: 10000
ports:
- name: http
containerPort: 80
Expand Down
8 changes: 7 additions & 1 deletion addons/goldpinger/3.3.0-5.1.0/goldpinger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ spec:
app.kubernetes.io/name: goldpinger
app.kubernetes.io/instance: goldpinger
spec:
priorityClassName:
priorityClassName:
serviceAccountName: goldpinger
containers:
- name: goldpinger-daemon
Expand All @@ -112,6 +112,12 @@ spec:
valueFrom:
fieldRef:
fieldPath: status.podIP
- name: PING_TIMEOUT_MS
value: 2000
- name: CHECK_TIMEOUT_MS
value: 3000
- name: CHECK_ALL_TIMEOUT_MS
value: 10000
ports:
- name: http
containerPort: 80
Expand Down
8 changes: 7 additions & 1 deletion addons/goldpinger/3.5.1-5.2.0/goldpinger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ spec:
app.kubernetes.io/name: goldpinger
app.kubernetes.io/instance: goldpinger
spec:
priorityClassName:
priorityClassName:
serviceAccountName: goldpinger
containers:
- name: goldpinger-daemon
Expand All @@ -112,6 +112,12 @@ spec:
valueFrom:
fieldRef:
fieldPath: status.podIP
- name: PING_TIMEOUT_MS
value: 2000
- name: CHECK_TIMEOUT_MS
value: 3000
- name: CHECK_ALL_TIMEOUT_MS
value: 10000
ports:
- name: http
containerPort: 80
Expand Down
8 changes: 7 additions & 1 deletion addons/goldpinger/3.6.1-5.4.2/goldpinger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ spec:
app.kubernetes.io/name: goldpinger
app.kubernetes.io/instance: goldpinger
spec:
priorityClassName:
priorityClassName:
serviceAccountName: goldpinger
containers:
- name: goldpinger-daemon
Expand All @@ -112,6 +112,12 @@ spec:
valueFrom:
fieldRef:
fieldPath: status.podIP
- name: PING_TIMEOUT
value: 2s
- name: CHECK_TIMEOUT
value: 3s
- name: CHECK_ALL_TIMEOUT
value: 10s
ports:
- name: http
containerPort: 80
Expand Down
10 changes: 8 additions & 2 deletions addons/goldpinger/3.7.0-5.5.0/goldpinger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ spec:
app.kubernetes.io/name: goldpinger
app.kubernetes.io/instance: goldpinger
spec:
priorityClassName:
priorityClassName:
serviceAccountName: goldpinger
containers:
- name: goldpinger-daemon
Expand All @@ -125,11 +125,17 @@ spec:
value: "80"
- name: LABEL_SELECTOR
value: "app.kubernetes.io/name=goldpinger"

- name: POD_IP
valueFrom:
fieldRef:
fieldPath: status.podIP
- name: PING_TIMEOUT
value: 2s
- name: CHECK_TIMEOUT
value: 3s
- name: CHECK_ALL_TIMEOUT
value: 10s
ports:
- name: http
containerPort: 80
Expand Down
10 changes: 8 additions & 2 deletions addons/goldpinger/3.7.0-5.6.0/goldpinger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ spec:
app.kubernetes.io/name: goldpinger
app.kubernetes.io/instance: goldpinger
spec:
priorityClassName:
priorityClassName:
serviceAccountName: goldpinger
containers:
- name: goldpinger-daemon
Expand All @@ -125,11 +125,17 @@ spec:
value: "80"
- name: LABEL_SELECTOR
value: "app.kubernetes.io/name=goldpinger"

- name: POD_IP
valueFrom:
fieldRef:
fieldPath: status.podIP
- name: PING_TIMEOUT
value: 2s
- name: CHECK_TIMEOUT
value: 3s
- name: CHECK_ALL_TIMEOUT
value: 10s
ports:
- name: http
containerPort: 80
Expand Down
8 changes: 7 additions & 1 deletion addons/goldpinger/3.7.0-6.0.1/goldpinger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ spec:
app.kubernetes.io/name: goldpinger
app.kubernetes.io/instance: goldpinger
spec:
priorityClassName:
priorityClassName:
serviceAccountName: goldpinger
containers:
- name: goldpinger-daemon
Expand All @@ -129,6 +129,12 @@ spec:
valueFrom:
fieldRef:
fieldPath: status.podIP
- name: PING_TIMEOUT
value: 2s
- name: CHECK_TIMEOUT
value: 3s
- name: CHECK_ALL_TIMEOUT
value: 10s
ports:
- name: http
containerPort: 80
Expand Down
26 changes: 22 additions & 4 deletions addons/goldpinger/template/testgrid/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,20 @@
postInstallScript: |
# find the goldpinger endpoint
export GP_ENDPOINT=$(kubectl get endpoints -n kurl goldpinger | grep -v NAME | awk '{ print $2 }')

# print goldpinger output (and fail if unable to connect to the service)
curl $GP_ENDPOINT/check_all
curl $GP_ENDPOINT/metrics

# Check if the support bundle spec was installed
echo "test whether the goldpinger support bundle spec was installed"
supportBundle=$(kubectl get secrets -n kurl kurl-goldpinger-supportbundle-spec -ojsonpath='{.data.support-bundle-spec}')
echo "$supportBundle"
echo "test if the content of the secret is a support bundle spec"
echo $supportBundle | base64 -d | grep 'kind: SupportBundle'
echo "test if the support bundle has 'troubleshoot.io/kind: support-bundle' label"
kubectl get secrets -n kurl kurl-goldpinger-supportbundle-spec -oyaml | grep 'troubleshoot.io/kind: support-bundle'

- name: upgrade from latest
installerSpec:
kubernetes:
Expand All @@ -40,7 +49,7 @@
postUpgradeScript: |
# find the goldpinger endpoint
export GP_ENDPOINT=$(kubectl get endpoints -n kurl goldpinger | grep -v NAME | awk '{ print $2 }')

# print goldpinger output (and fail if unable to connect to the service)
curl $GP_ENDPOINT/check_all
curl $GP_ENDPOINT/metrics
Expand Down Expand Up @@ -68,7 +77,7 @@
postUpgradeScript: |
# find the goldpinger endpoint
export GP_ENDPOINT=$(kubectl get endpoints -n kurl goldpinger | grep -v NAME | awk '{ print $2 }')

# print goldpinger output (and fail if unable to connect to the service)
curl $GP_ENDPOINT/check_all
curl $GP_ENDPOINT/metrics
Expand All @@ -91,7 +100,16 @@
postInstallScript: |
# find the goldpinger endpoint
export GP_ENDPOINT=$(kubectl get endpoints -n kurl goldpinger | grep -v NAME | awk '{ print $2 }')

# print goldpinger output (and fail if unable to connect to the service)
curl $GP_ENDPOINT/check_all
curl $GP_ENDPOINT/metrics

# Check if the support bundle spec was installed
echo "test whether the goldpinger support bundle spec was installed"
supportBundle=$(kubectl get secrets -n kurl kurl-goldpinger-supportbundle-spec -ojsonpath='{.data.support-bundle-spec}')
echo "$supportBundle"
echo "test if the content of the secret is a support bundle spec"
echo $supportBundle | base64 -d | grep 'kind: SupportBundle'
echo "test if the support bundle has 'troubleshoot.io/kind: support-bundle' label"
kubectl get secrets -n kurl kurl-goldpinger-supportbundle-spec -oyaml | grep 'troubleshoot.io/kind: support-bundle'
6 changes: 6 additions & 0 deletions addons/goldpinger/template/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ extraEnv:
valueFrom:
fieldRef:
fieldPath: status.podIP
- name: PING_TIMEOUT
value: 2s
- name: CHECK_TIMEOUT
value: 3s
- name: CHECK_ALL_TIMEOUT
value: 10s

service:
type: ClusterIP # originally "LoadBalancer" (replicated)
Expand Down
19 changes: 19 additions & 0 deletions addons/goldpinger/template/yaml/troubleshoot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
apiVersion: v1
kind: Secret
metadata:
name: kurl-goldpinger-supportbundle-spec
labels:
troubleshoot.io/kind: support-bundle
stringData:
support-bundle-spec: |
apiVersion: troubleshoot.sh/v1beta2
kind: SupportBundle
metadata:
name: goldpinger
spec:
collectors:
- goldpinger:
collectorName: kurl-goldpinger
namespace: kurl
analyzers:
- goldpinger: {}
Loading