Use Collection.addAll wherever applicable.

rife2 · May 29, 2024 · b4c8952 · b4c8952
1 parent 81ab2e8
commit b4c8952
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 19 deletions.
diff --git a/src/main/java/rife/bld/extension/CompileKotlinOperation.java b/src/main/java/rife/bld/extension/CompileKotlinOperation.java
@@ -154,7 +154,7 @@ public File buildTestDirectory() {
      * @return this operation instance
      */
     public CompileKotlinOperation compileMainClasspath(String... classpath) {
-        compileMainClasspath_.addAll(Arrays.asList(classpath));
+        Collections.addAll(compileMainClasspath_, classpath);
         return this;
     }
 
@@ -205,7 +205,7 @@ public CompileKotlinOperation compileOptions(CompileKotlinOptions options) {
      * @return this operation instance
      */
     public CompileKotlinOperation compileTestClasspath(String... classpath) {
-        compileTestClasspath_.addAll(Arrays.asList(classpath));
+        Collections.addAll(compileTestClasspath_, classpath);
         return this;
     }
 
@@ -398,7 +398,7 @@ public CompileKotlinOperation fromProject(BaseProject project) {
      * @return this operation instance
      */
     public CompileKotlinOperation mainSourceDirectories(File... directories) {
-        mainSourceDirectories_.addAll(List.of(directories));
+        Collections.addAll(mainSourceDirectories_, directories);
         return this;
     }
 
@@ -460,7 +460,7 @@ public Collection<File> mainSourceFiles() {
      * @return this class instance
      */
     public CompileKotlinOperation plugins(String... plugins) {
-        plugins_.addAll(List.of(plugins));
+        Collections.addAll(plugins_, plugins);
         return this;
     }
 
@@ -526,7 +526,7 @@ private Collection<File> sources(Collection<File> files, Collection<File> direct
      * @return this operation instance
      */
     public CompileKotlinOperation testSourceDirectories(File... directories) {
-        testSourceDirectories_.addAll(List.of(directories));
+        Collections.addAll(testSourceDirectories_, directories);
         return this;
     }
 

diff --git a/src/main/java/rife/bld/extension/CompileKotlinOptions.java b/src/main/java/rife/bld/extension/CompileKotlinOptions.java
@@ -19,6 +19,7 @@
 import java.io.File;
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.Collections;
 import java.util.List;
 
 import static rife.bld.extension.CompileKotlinOperation.isNotBlank;
@@ -95,7 +96,7 @@ public CompileKotlinOptions apiVersion(int version) {
      * @return this operation instance
      */
     public CompileKotlinOptions argFile(String... files) {
-        argFile_.addAll(List.of(files));
+        Collections.addAll(argFile_, files);
         return this;
     }
 
@@ -257,7 +258,7 @@ public List<String> args() {
      * @return this operation instance
      */
     public CompileKotlinOptions classpath(String... paths) {
-        classpath_.addAll(List.of(paths));
+        Collections.addAll(classpath_, paths);
         return this;
     }
 
@@ -455,7 +456,7 @@ public CompileKotlinOptions noWarn(boolean noWarn) {
      * @return this operation instance
      */
     public CompileKotlinOptions optIn(String... annotations) {
-        optIn_.addAll(List.of(annotations));
+        Collections.addAll(optIn_, annotations);
         return this;
     }
 
@@ -477,7 +478,7 @@ public CompileKotlinOptions optIn(Collection<String> annotations) {
      * @return this operation instance
      */
     public CompileKotlinOptions options(String... options) {
-        options_.addAll(List.of(options));
+        Collections.addAll(options_, options);
         return this;
     }
 
@@ -551,7 +552,7 @@ public CompileKotlinOptions progressive(boolean progressive) {
      * @return this operation instance
      */
     public CompileKotlinOptions scriptTemplates(String... classNames) {
-        scriptTemplates_.addAll(List.of(classNames));
+        Collections.addAll(scriptTemplates_, classNames);
         return this;
     }
 

diff --git a/src/main/java/rife/bld/extension/dokka/DokkaOperation.java b/src/main/java/rife/bld/extension/dokka/DokkaOperation.java
@@ -309,7 +309,7 @@ public DokkaOperation globalLinks(Map<String, String> globalLinks) {
      * @return this operation instance
      */
     public DokkaOperation globalPackageOptions(String... options) {
-        globalPackageOptions_.addAll(Arrays.asList(options));
+        Collections.addAll(globalPackageOptions_, options);
         return this;
     }
 
@@ -342,7 +342,7 @@ public DokkaOperation globalPackageOptions(Collection<String> options) {
      * @return this operation instance
      */
     public DokkaOperation globalSrcLink(String... links) {
-        globalSrcLinks_.addAll(Arrays.asList(links));
+        Collections.addAll(globalSrcLinks_, links);
         return this;
     }
 
@@ -368,7 +368,7 @@ public DokkaOperation globalSrcLink(Collection<String> links) {
      * @return this operation instance
      */
     public DokkaOperation includes(String... files) {
-        includes_.addAll(Arrays.asList(files));
+        Collections.addAll(includes_, files);
         return this;
     }
 
@@ -555,7 +555,7 @@ public DokkaOperation pluginConfigurations(Map<String, String> pluginConfigurati
      * @return this operation instance
      */
     public DokkaOperation pluginsClasspath(String... jars) {
-        pluginsClasspath_.addAll(Arrays.asList(jars));
+        Collections.addAll(pluginsClasspath_, jars);
         return this;
     }
 

diff --git a/src/main/java/rife/bld/extension/dokka/SourceSet.java b/src/main/java/rife/bld/extension/dokka/SourceSet.java
@@ -241,7 +241,7 @@ public List<String> args() {
      * @return this operation instance
      */
     public SourceSet classpath(String... files) {
-        classpath_.addAll(Arrays.asList(files));
+        Collections.addAll(classpath_, files);
         return this;
     }
 
@@ -371,7 +371,7 @@ public SourceSet externalDocumentationLinks(Map<String, String> externalDocument
      * @return this operation instance
      */
     public SourceSet includes(String... files) {
-        includes_.addAll(Arrays.asList(files));
+        Collections.addAll(includes_, files);
         return this;
     }
 
@@ -535,7 +535,7 @@ public SourceSet perPackageOptions(Collection<String> perPackageOptions) {
      * @return this operation instance
      */
     public SourceSet perPackageOptions(String... perPackageOptions) {
-        perPackageOptions_.addAll(List.of(perPackageOptions));
+        Collections.addAll(perPackageOptions_, perPackageOptions);
         return this;
     }
 
@@ -581,7 +581,7 @@ public SourceSet samples(Collection<String> samples) {
      * @return this operation instance
      */
     public SourceSet samples(String... samples) {
-        samples_.addAll(List.of(samples));
+        Collections.addAll(samples_, samples);
         return this;
     }
 
@@ -635,7 +635,7 @@ public SourceSet src(Collection<String> src) {
      * @return this operation instance
      */
     public SourceSet src(String... src) {
-        src_.addAll(List.of(src));
+        Collections.addAll(src_, src);
         return this;
     }