Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JA] Update translations #1077

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

[JA] Update translations #1077

wants to merge 3 commits into from

Conversation

tequdev
Copy link
Contributor

@tequdev tequdev commented Nov 7, 2024

High Level Overview of Change

Context of Change

Type of Change

  • Translation Updates

@pdp2121
Copy link
Collaborator

pdp2121 commented Nov 12, 2024

Hi @tequdev , could you include the new translation for the key header.search.placeholder as mentioned in #1073 as well? Thank you!

@tequdev
Copy link
Contributor Author

tequdev commented Feb 19, 2025

Hi @tequdev , could you include the new translation for the key header.search.placeholder as mentioned in #1073 as well? Thank you!

fixed!

@@ -6,7 +6,7 @@
"assets.no_issued_message": "トークンが見つかりません。",
"assets.no_nfts_message": "NFTが見つかりません。",
"network": "ネットワーク",
"amendments": null,
"amendments": "Amendment",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are some words written out in English?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some words are commonly used in English in the Japanese community.

In particular, “Amendment” is an English word that users from non-English speaking countries often see (through services such as XRPScan).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants