Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shapely 2.0.7 #26

Closed
wants to merge 2 commits into from
Closed

Add Shapely 2.0.7 #26

wants to merge 2 commits into from

Conversation

JayTicku
Copy link

Used for calculating if the pose estimate from the Limelight is within the field's boundaries given the the field is not a rectangle.

@virtuald
Copy link
Member

This requires libgeo, which is a non-python library. We would need to package it similar to how we package OpenBlas, but because it depends on a geos-config executable instead of a pkg-config file that might not work well either.

This is likely a bunch of work.

@virtuald
Copy link
Member

FWIW, unless there's a compelling reason that we need to package this library, I'm unlikely to do the work myself. However, if you can figure out a reasonable way how to make a cross-compiled wheel locally, I'd be willing to get the rest of the packaging work integrated here.

@JayTicku
Copy link
Author

What about matplotlib? Would that work?

@JayTicku
Copy link
Author

JayTicku commented Feb 26, 2025

Also, would this repository be able to package Shapely without CPython? It's the official wheel builder from the Shapely developers. Shapely Wheels

@virtuald
Copy link
Member

That stuff hasn't been updated in 3 years, I think the actual wheel building happens at https://github.com/shapely/shapely/blob/main/.github/workflows/release.yml#L54

@JayTicku
Copy link
Author

Yeah, I think you're right. Would you be able to use this to package the library or would I need to use another library?

@virtuald
Copy link
Member

virtuald commented Feb 26, 2025

I don't think what they have supports cross-compiling. You'd have to try it. Or read the documentation.

@JayTicku
Copy link
Author

Sorry. I might be misreading this and I don't understand this fully but in release.yml file you linked above, doesn't the build_wheels_linux part include the ARM architecture that the Roborio uses?

@virtuald
Copy link
Member

If that were the case, then you could just download the wheel from pypi and use it. That isn't the case, the roborio uses a special tag because the ABI is different and because it's ARM32 (not aarch64).

@virtuald virtuald mentioned this pull request Feb 26, 2025
@virtuald
Copy link
Member

I lied and spent a little bit of time trying to get this working, see #27

@virtuald virtuald closed this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants