-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RSA MGF1 signature types #200
base: master
Are you sure you want to change the base?
Conversation
Relies on PR robrichards/xmlseclibs#200 so explicitly depending on commit in the meantime
The Travis CI build is failed because the default dist has been changed. According to the Travis CI blog post, the default dist change into To let |
Fixed the trusty issue, but this requires more work:
No idea why the version of phpunit that is included in a travis vm is incompatible with the version of php in the same vm. |
Hi @liamdennehy, thanks for your concern. The PHPUnit version problem is about internal Travis CI environment. Some useful discussion is here. To avoid this internal Travis problem, I suggest we can consider using the |
Last three commits have been addressing that, 4857aeb provides for composer install when required and fe4c990 includes better script readability. Build times have unfortunately increased, but still tolerable. https://travis-ci.org/robrichards/xmlseclibs/builds/585488348 is now a pleasant shade of green... |
Note This PR still has no tests, and especially has only been made to validate, but not produce the required signature in my own exemplar. |
I don't think the new scripts complicate things too much, though this is the first dependency in the project's travis build so I only |
Yes. I think it's about another PR and issue. |
I could not get this to work correctly on an external created signature, therefore used this code as base for another pullrequest #222 |
I have no idea what I am doing! Someone with crypto expertise please check my work! 😄
It seems OAEP and MGF1 refer to the same (or are simply included) underlying functions, so simply extending the XMLSecurityKey class with the new definitions in RFC6931#Section-2.3.10 does the job, but maybe it's not that simple.
Tested to correctly verify against sample in #199, unable to test generation, so no units included either.