Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could not render chart without renderTo #15

Merged
merged 3 commits into from
Feb 28, 2014
Merged

Could not render chart without renderTo #15

merged 3 commits into from
Feb 28, 2014

Commits on Jun 17, 2013

  1. Add a chart-obj attribute to the directive to get a reference from th… 

    …e controller to highcharts
    @stissot
    stissot committed Jun 17, 2013
    Configuration menu
    Copy the full SHA
    15ae942 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2014

  1. Merge remote-tracking branch 'upstream/master' 

    Conflicts:
	src/directives/highchart.js
    @PowerKiKi
    PowerKiKi committed Feb 28, 2014
    Configuration menu
    Copy the full SHA
    9df567b View commit details
    Browse the repository at this point in the history

  2. renderTo was lost and chart could not render 

    Since dropping jQuery depedency in favor of angular.extend() it was not
possible to render a chart without specifying manually the renderTo
property. This was due to the fact that angular.extend() is not recursive
(whereas jQuery was).

To avoid adding depedency we merge manually the few properties.
    @PowerKiKi
    PowerKiKi committed Feb 28, 2014
    Configuration menu
    Copy the full SHA
    3d2273b View commit details
    Browse the repository at this point in the history