rename depth/image_raw to depth_raw/image #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, both depth/image and depth/image_raw publish the same camera_info topic (depth/camera_info) - this has several issues: * subscribing to either image causes both to be published along with their respective camera_info * remapping either camera_info, remaps both * In Jazzy, it appears that the double camera_info also causes minor issues with message_filters in downstream packages
mikeferguson
commented
Aug 7, 2024
| @@ -398,7 +398,6 @@ void OpenNI2Driver::colorConnectCb() | |||
| } | |||
| std::lock_guard<std::mutex> lock(connect_mutex_); | |||
|
|
|||
| // This does not appear to work | |||
There was a problem hiding this comment.
these comments were left over and should have been removed when lazy subscribers were implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, both depth/image and depth/image_raw publish the same camera_info topic (depth/camera_info) - this has several issues: