-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Boolean variables #403
base: melodic-devel
Are you sure you want to change the base?
Support Boolean variables #403
Conversation
Hi, |
This fix look okay, but I am unsure about PDO support. |
I see, I was mainly interested in the DCF parser, to be able to parse boolean datatype from some manufacturer specific objects that can't be mapped to PDO. I agree PDO support should be checked before merging, or if canopen_master doesn't support granularity 1, do you think the parser could just reject files which have a mappable boolean object ? |
I think it should be possible to fail the init service, if a boolean gets mapped. |
Hi guys, thanks for the interest. I do have a device with Boolean variables. I checked that parsing and SDOs are okay, but not PDOs. I'm happy to test whether PDO works. Would that help with having this merged? |
Hi @lkm1321, were you able to test your PR with PDOs ? |
Hi @Roboprotos, I did a quick test of this feature with our device (Roboteq RGBL1896) but doesn't seem to work correctly. SDO just seems to read 0 even though the underlying value should be 1. I'm not sure if the fault is in |
Hi,
This PR adds support for Boolean (DataType=0x0001) variables. The new features are:
Addresses #268