Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ur3 visual mesh #524

Open
wants to merge 4 commits into
base: melodic-devel-staging
Choose a base branch
from

Conversation

Briancbn
Copy link
Member

@Briancbn Briancbn commented Jul 7, 2020

Fix #425
For Wrist3 Node 1 (ring) I simply added a edge split modifier and shade smooth
For Wrist3 Node 0 (end-effector) I rebuild the mesh in blender (maybe because I am not good enough or the resolution of the STL is too low, I don't see the screw holes coming back easily with edge split). It was drawn on top of the original STL so there should be no dimensional problem here.
For Wrist2 and Wrist1 blue logo cap, I use the UR3e ones, remove the screws. The original mesh will takes a very long time to fix (maybe I am not that good). Since I cannot regenerate STL

You can cherry-pick this commit onto kinetic-devel branch

Before:
Before

After:
after

Final:
Final

@Briancbn Briancbn changed the title Fix ur3 visual mesh WIP: Fix ur3 visual mesh Jul 7, 2020
@Briancbn Briancbn changed the title WIP: Fix ur3 visual mesh Fix ur3 visual mesh Jul 7, 2020
@gavanderhoorn
Copy link
Member

The meshes look really nice @Briancbn.

Could you comment on the file size difference?

Good looking meshes are important, but if it increases the size of the files too much (Collada can get very verbose), we may need to tweak them a little.

@Briancbn
Copy link
Member Author

Briancbn commented Jul 7, 2020

Before
716K wrist1.dae
724K wrist2.dae
44K wrist3.dae

After
1.3M wrist1.dae
1.2M wrist2.dae
388K wrist3.dae

I can try to reduce wrist3 if you think the differences are too big.

Copy link
Member

@ipa-nhg ipa-nhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Briancbn thanks for this contribution! Great job, I really like the new visualization.

I am ok with the new sizes. I let @gavanderhoorn to give the last 👍 and merge this

@ipa-nhg ipa-nhg linked an issue Jul 8, 2020 that may be closed by this pull request
@gavanderhoorn gavanderhoorn force-pushed the melodic-devel-staging branch from 2bade90 to 6a64eb0 Compare October 8, 2020 09:37
@gavanderhoorn
Copy link
Member

While this certainly improves the smoothness of the mesh, it increases their size 2x (wrist 3 about 9 times).

Personally I feel that's a bit too much, but I'm just one voice here.

It seems @ipa-nhg is ok with it, so it's a tie.

Perhaps someone else can weigh in.

Signed-off-by: Chen Bainian <[email protected]>

Readjust scale back to STL

Signed-off-by: Chen Bainian <[email protected]>
Signed-off-by: Chen Bainian <[email protected]>
@Briancbn Briancbn force-pushed the pr-fix-ur3-visual-mesh branch from f77b173 to 2fc8902 Compare September 29, 2021 07:35
@Briancbn
Copy link
Member Author

I will try to reduce the wrist 3 mesh

@gavanderhoorn
Copy link
Member

The other two may be more efficient to reduce. They are the main cause of the size increase I believe.

@Briancbn
Copy link
Member Author

For Wrist2 and Wrist1 blue logo cap, I use the UR3e ones, remove the screws. The original mesh will takes a very long time to fix (maybe I am not that good). Since I cannot regenerate STL

@gavanderhoorn For the other 2, it is pretty much the best I can do here based on my ability. As the automatic generated meshes are not clean (nice quad for instance), it is pretty hard to directly use "decimate".

I assume as it was not an issue in ur3e, it could still be ok here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad quality visual meshes for UR3 in ros Kinetic
3 participants